1023534 - [VsD Refresh] Lockscreen Visual Refresh > Pin code screen > Camera icon position

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect, P1)

Description

[Amy Lee [:amylee] UX]

The position of the camera icon is not true to spec. Please see attached. Thanks!

Comment 1

[Amy Lee [:amylee] UX]

Attachment: pin_code_screen.png

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: 2014-06-11-15-46-54.png

Hi Amy,

Please check if the attached screenshot is good, thanks (ps. the camera is positioned against 8.5rem Time string, not the current 7.7rem Time string)

Comment 3

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch

Comment 4

[Amy Lee [:amylee] UX]

Comment on attachment 8438260 [details]
2014-06-11-15-46-54.png

Alignment looks good! Thanks

Comment 5

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8438262 [details] [review]
Patch

Hi Tim, could you review this trivial patch for me? Thanks!

Comment 6

[John Lu [:mnjul][Please NI or I'll miss]]

Master: https://github.com/mozilla-b2g/gaia/commit/d9db7f2783d0979366122bd838343827cfaaf5f9

Comment 7

[bhavana bajaj [:bajaj]]

This is a polish issues, not something we would block a release ok, please seek approval here to consider it for 2.0 uplift.

Comment 8

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8438262 [details] [review]
Patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]

[Bug caused by] (feature/regressing bug #): bug 1023534 was because of not-to-spec implementation of bug 950884

[User impact] if declined: minimal, as this is only cosmetic change

[Testing completed]: Yes.

[Risk to taking this patch] (and alternatives if risky): minimal, as this is only cosmetic change

[String changes made]: None

Comment 9

[bhavana bajaj [:bajaj]]

Removing the blocking as the uplift will address the 2.0 concern anyway and refer to the blocking decision in comment #7

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/c804ed87d9a888b8c355d29a48cf73cea1aca1d5

Comment 11

[Sue]

Attachment: screenshot of Flame 2.1

Hi Hubert,
Could you help with it, thanks.
This issue has been verified successfully on Flame v2.1
See attachment: Flame 2.1.png
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141205.035305
FW-Date         Fri Dec  5 03:53:16 EST 2014
Bootloader      L1TC00011880

This issue has been verified unsuccessfully on Flame v2.0. Camera icon is not horizontally aligned to date.
See attachment: Flame 2.0.png
Reproducing rate: 5/5
Flame 2.0 versions:
Gaia-Rev        856863962362030174bae4e03d59c3ebbc182473
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/2d0860bd0225
Build-ID        20141209000202
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141209.032456
FW-Date         Tue Dec  9 03:25:13 EST 2014
Bootloader      L1TC00011880

Comment 12

[Sue]

Attachment: screenshot of Flame 2.0