102354 - Download dialog should use "()" not "[]" for known MIME types

Status: RESOLVED WORKSFORME

(Core Graveyard :: File Handling, defect)

Description

[Hixie (not reading bugmail)]

When you download a file with a MIME type with a registered helper app, the
"Downloading file" dialog that prompts you to select how you want the file
opened will give the following prompt:

   You have chosen to download a file of type "WinZip File"
   [application/x-zip-compressed] from 
   ftp://ftp.mozilla.org/pub/mozilla/night/latest-trunk/

This is rather ugly. Better would be to use round brackets:

   You have chosen to download a file of type "WinZip File"
   (application/x-zip-compressed) from 
   ftp://ftp.mozilla.org/pub/mozilla/night/latest-trunk/

Comment 1

[sairuh (rarely reading bugmail)]

->bill

Comment 2

[Bill Law]

cc:ing German; this is implemented as spec'd, is using () really prettier?  I
don't much care myself, but I hate to "fix" this and then get another bug
tomorrow from German saying that he misses the cute little square brackets...

Comment 3

[Hixie (not reading bugmail)]

bill: Agreed! I don't want to put you in the middle here. :-)

german: Was your spec's use of square brackets indeed intentional?

Comment 4

[sairuh (rarely reading bugmail)]

spam: over to File Handling.

Comment 5

[Hixie (not reading bugmail)]

german is no longer working on Mozilla. mpt?

Comment 6

[Matthew T (active 1999-2002)]

Yes, round brackets, please!

Comment 7

[Boris Zbarsky [:bzbarsky]]

reassigning to marlon so we can get his opinion sometime in the near future
(today?  tomorrow?  :P).  That way we can know we're avoiding a big
bracket/paren war.

Comment 8

[Hixie (not reading bugmail)]

marlon?

Comment 9

[Eli Friedman]

Attachment: Patch changing square brackets in Download dialog to round brackets

Patch

Comment 10

[Hixie (not reading bugmail)]

r=hixie.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Is this still relevant?  We now put no brackets at all around the type.

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

http://lxr.mozilla.org/seamonkey/source/embedding/components/ui/helperAppDlg/locale/en-US/nsHelperAppDlg.dtd
- only round brackets there. marking wfm.