1023638 - toolkit/components/captivedetect/test/unit/test_captive_portal_found_303.js 303's to example.org

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Nathan Froyd [:froydnj]]

With the patches from bug 995417 applied:

15:42:38     INFO -  06-10 18:10:17.454  4278  4288 I Gecko   : [4278] WARNING: Non-local hostname example.org resolved: file ../../../gecko/netwerk/dns/nsHostResolver.cpp, line 1193
15:42:38     INFO -  06-10 18:10:17.454  4278  4280 I Gecko   : BAD CONNECT: connecting to example.org
15:42:38     INFO -  06-10 18:10:17.454  4278  4280 F MOZ_CRASH: Hit MOZ_CRASH(Attempting to connect to non-local address!) at ../../../../gecko/netwerk/base/src/nsSocketTransport2.cpp:1190

We shouldn't be using remote URLs in xpcshell tests.  I think the correct thing to do here is spin up a second (!) http server to redirect to.

It's curious that this is only a problem on b2g (noticed on the emulators), but I suspect this is just some timing issue.  The network requests must be canceled before going all the way through on desktop or something similar.

Comment 1

[Nathan Froyd [:froydnj]]

(In reply to Nathan Froyd (:froydnj) from comment #0)
> It's curious that this is only a problem on b2g (noticed on the emulators),
> but I suspect this is just some timing issue.

Ah, these tests were a) just enabled on b2g and MOZ_CAPTIVEDETECT is only enabled for b2g (why?!).

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: fix test_captive_portal_found_303.js to not redirect to example.org

Since we can't connect to example.org, the next best thing is localhost.  But
connect to a separate http server, so as to preserve the semantics of using a
separate page for the redirect.

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

(In reply to Nathan Froyd (:froydnj) from comment #1)
> (In reply to Nathan Froyd (:froydnj) from comment #0)
> > It's curious that this is only a problem on b2g (noticed on the emulators),
> > but I suspect this is just some timing issue.
> 
> Ah, these tests were a) just enabled on b2g and MOZ_CAPTIVEDETECT is only
> enabled for b2g (why?!).

Captive portal detection is only used by Firefox OS now and we didn't reach the consensus whether to use it on Firefox. It'll be better to use pref instead of compile option if we want this feature on Firefox.

Comment 4

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8438089 [details] [diff] [review]
fix test_captive_portal_found_303.js to not redirect to example.org

Review of attachment 8438089 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 5

[Nathan Froyd [:froydnj]]

Thanks for the fast review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff950ef6212f

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ff950ef6212f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e59ad1a713fa
https://hg.mozilla.org/releases/mozilla-beta/rev/8688d45141f6
https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/46cbab3faf7d
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/634b8bb42eea