Closed
Bug 1023655
Opened 11 years ago
Closed 11 years ago
unnecessary DOCTYPEs in SVG resources cause failed DTD loads and console warnings
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 33
People
(Reporter: heycam, Assigned: heycam)
Details
Attachments
(1 file)
20.65 KB,
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
There are a few SVG resources we use that have a DOCTYPE that references the SVG DTD. This causes an attempt to load resource://gre/res/dtd/svg11.dtd which fails and causes a console warning like:
[27825] WARNING: Failed to open external DTD: publicId "-//W3C//DTD SVG 1.1//EN" systemId "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd" base "file:///z/moz2/b/toolkit/themes/linux/global/icons/close.svg" URL "resource://gre/res/dtd/svg11.dtd": file /z/moz2/b/parser/htmlparser/src/nsExpatDriver.cpp, line 702
The DOCTYPE is useless and can be removed from these resources.
Attachment #8438071 -
Flags: review?(bmcbride)
Updated•11 years ago
|
Attachment #8438071 -
Flags: review?(bmcbride) → review+
Assignee | ||
Comment 1•11 years ago
|
||
Assignee: nobody → cam
Status: NEW → ASSIGNED
Comment 2•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Comment 3•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/e09ede116cef5359701350ff1b69d52d39a953dc
Bug 1023655 - Remove DOCTYPEs from SVG documents to avoid failed DTD loads. r=Unfocused
You need to log in
before you can comment on or make changes to this bug.
Description
•