1023764 - [Loop] Keep Contacts Info updated

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Borja Salguero [:borjasalguero]]

We need to keep a cached version of the contacts we are using in our call log, but we need to update this info in our IndexedDB if any change happens in the Contact List.

As well we will create a ContactsHelper for retrieving the info of a contact given an ID, and other methods related.

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Attachment: WIP

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8455465 [details] [review]
WIP

LGTM. r=me

I'm not very familiar with the call log/contact stuff. I would prefer Borja to take a look also before landing this.

Thanks Fernando!

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #3)
> Comment on attachment 8455465 [details] [review]
> WIP
> 
> LGTM. r=me
> 
> I'm not very familiar with the call log/contact stuff. I would prefer Borja
> to take a look also before landing this.

Oops, forgot to comment that do not forget to rebase this work as we already landed the bumping up version logic. Once you rebase, the version should be bumped up.

Comment 5

[Borja Salguero [:borjasalguero]]

Comment on attachment 8455465 [details] [review]
WIP

I think that there are some things to improve, so I've added some comments in Github. I'm keeping the r? flag in order to recheck this when ready. Thanks Fernando!

Comment 6

[Borja Salguero [:borjasalguero]]

Comment on attachment 8455465 [details] [review]
WIP

This patch is working perfectly! R+!

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/07f04cacb73b5f5cd83e242780c895cd0f623f95