1023877 - Reference workload does not work on Flame

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Performance, defect, P1)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

The reference workload tries to push to /sdcard which does not exist on Flame. It should be updated to push to /storage/sdcard0 or /storage/sdcard1 when the target is Flame.

Comment 1

[Jon Hylands [:jhylands]]

Attachment: Pull Request for fix

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8442205 [details]
Pull Request for fix

I haven't tested, but this looks good to me. We can probably remove the commented out lines too.

If we have another device in the future with a different storage path then we'll need to add that too. A more robust solution would be nice, but we shouldn't block on that.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I'll test this on Hamachi as requested by Jon on IRC. If it works, I'll merge it.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8442205 [details]
Pull Request for fix

After testing, it appears this is not working 100%. The gallery workload assumes the DCIM/100MZLLA path will exist in the storage location, however it may not.

I also think we should exit if any workload fails to push. At the moment we ignore any failures and exit with a code of 0. This means that in continuous integration we may miss important issues. Let me know if you'd like me to raise this as a separate bug.

Comment 5

[Jon Hylands [:jhylands]]

Lets definitely raise that as a separate bug. I've updated the PR to fix the gallery issue.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8442205 [details]
Pull Request for fix

Looks good. I'll merge this once Try/Travis are happy.

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Jon Hylands [:jhylands] from comment #5)
> Lets definitely raise that as a separate bug.

I've raised bug 1028261.

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed in:
https://github.com/mozilla-b2g/gaia/commit/75b7384aca898ce177be17023d2dc4392e9f10dd

Comment 9

[:Eli Perelman]

Comment on attachment 8442205 [details]
Pull Request for fix

The tests on Datazilla are failing to install the reference-workload-light on the Flame on 2.0 because it is installing to the incorrect SD card location. We need this uplifted to 2.0 so we can run these tests correctly against a Flame.

[Bug caused by] (feature/regressing bug #): 1023877
[User impact] if declined: n/a
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): low since this affects workload scripts for testing, not user facing
[String changes made]: n/a

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/851d01bf2ccb4a6501108e3da0b9744eb4a601df