1023911 - [Contacts] Investigate why integration test contacts_shortcuts_test.js is failing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

We are seeing the following:

 Error: timeout exceeded!

at Object.Client.waitForSync (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:682:16)

at Object.Client.waitFor (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:650:60)

at Object.MarionetteHelper.waitForElement (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-helper/index.js:142:12)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/communications/contacts/test/marionette/contacts_shortcuts_test.js:72:31)

at callFn (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:223:21)

at Test.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:216:7)

at Runner.runTest (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:373:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:451:12

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:298:14)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:308:7

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:246:23)

at Object._onImmediate (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:275:5)

at processImmediate [as _immediateCallback] (timers.js:330:15)

Possible candidates to watch are:

bug 1013207
bug 1022475

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Running 50 times the suite enabled to try to check for a failure pattern:

https://travis-ci.org/arcturus/gaia/builds/27329103

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Running 50 times with bug 1013207 reverted:

https://travis-ci.org/arcturus/gaia/builds/27329650

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Running 50 times with bug 1022475 reverted:

https://travis-ci.org/arcturus/gaia/builds/27329849

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Last 50 jobs with both reverts:

https://travis-ci.org/arcturus/gaia/builds/27329990


All the previous jobs are running just the suite that was failing in contacts

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Yes,

I still can see the famous output:

E/GeckoConsole( 5197): [JavaScript Error: "TypeError: fb.isFbContact is not a function" {file: "app://communications.gaiamobile.org/contacts/js/views/list.js" line: 1006}]
E/GeckoConsole( 5197): [JavaScript Error: "TypeError: container is undefined" {file: "app://communications.gaiamobile.org/dialer/js/call_log.js" line: 943}]
E/GeckoConsole( 5197): [JavaScript Error: "TypeError: devContact is undefined" {file: "app://communications.gaiamobile.org/shared/js/fb/fb_reader_utils.js" line: 101}]

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #5)
> Yes,
> 
> I still can see the famous output:
> 
> E/GeckoConsole( 5197): [JavaScript Error: "TypeError: fb.isFbContact is not
> a function" {file:
> "app://communications.gaiamobile.org/contacts/js/views/list.js" line: 1006}]
> E/GeckoConsole( 5197): [JavaScript Error: "TypeError: container is
> undefined" {file:
> "app://communications.gaiamobile.org/dialer/js/call_log.js" line: 943}]
> E/GeckoConsole( 5197): [JavaScript Error: "TypeError: devContact is
> undefined" {file:
> "app://communications.gaiamobile.org/shared/js/fb/fb_reader_utils.js" line:
> 101}]

w00t ... wrong bug, sorry guys

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Just launched a new batch, saw that we could have a problem meanwhile the keyboard is expanded, we could try to touch an area of the shortcut that may be not visible.

Reduced that area and put the test to run here:
https://travis-ci.org/arcturus/gaia/builds/27434271

Locally they pass, but we need to see how travis likes this new try.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Looking promising 10 jobs finished ok:

https://travis-ci.org/arcturus/gaia/builds/27434271


Now running 50 to see whats going on:

https://travis-ci.org/arcturus/gaia/builds/27435888

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Interesting results, in the 50 run we don't have any more fails from the original ofending test, but now we see another test, failing intermintent.

I will apply same solution, try to touch closer to the top to avoid touch in the keybard

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Here are the latest results:

https://travis-ci.org/arcturus/gaia/builds/27472055

We are getting closer, now we get ride of the errors from the proper shortcuts test, but we have 4 failures, in this case is not in the proper test itself, but in the helper library used in all the contacts integration tests:

at Object.Contacts.waitForFormTransition (/home/travis/build/arcturus/gaia/apps/communications/contacts/test/marionette/lib/contacts.js:164:17)

at Object.Contacts.enterContactDetails (/home/travis/build/arcturus/gaia/apps/communications/contacts/test/marionette/lib/contacts.js:188:10)

This is related to the input of the contact, don't know if the keyboard has anything to do with this.

Will retry again this patch + backing out the keyboard changes that we tried before.

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Definitely looks like backing out bug 1013207 helps with the results:

https://travis-ci.org/arcturus/gaia/builds/27481166

That bug is related to lazy loading of keyboard stuff, which will explaing why we have problems and timeouts when using the keyboard.

Anyway, don't think that is enough to backout the patch, so will try to provide a solutions for the tests. 

What could provide is a measure of maybe that patch is not performing as good as we though in terms of performance.

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Yeah,

seems we found it:

https://travis-ci.org/arcturus/gaia/builds/27505468

My last change was modifying the way we input the contact and seems we got ride of those intermintents

Preparing PR with all the changes

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to pr 20503

Anthony would you mind to take a look?

Comment 14

[Anthony Ricaud (:rik)]

Comment on attachment 8440027 [details] [review]
Pointer to pr 20503

Sorry I have almost no experience in integration tests.

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8440027 [details] [review]
Pointer to pr 20503

Hei Cristian,

could you take a look.

I modified the helper function to check when the form is hidden, apparently we were having some timeouts when keyboard was in place.

Comment 16

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8440027 [details] [review]
Pointer to pr 20503

LGTM as usual, thanks Fran

Comment 17

[Francisco Jordano [:arcturus] [:francisco]]

Thanks Cristian,

won't ask for uplitfting to 2.0, will merge first on master and then wait to see how it behaves.

Landed:

https://github.com/arcturus/gaia/commit/8ed8d0753709540ae39896a6c1f5c9aa7aa578c2