1024151 - webgl-1.0.3 conformance failure alpha depth stencil antialias

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Walter Litwinczyk [:walter]]

http://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-attributes-alpha-depth-stencil-antialias.html

Currently a depth buffer is always forced when a stencil buffer is present

http://dxr.mozilla.org/mozilla-central/source/content/canvas/src/WebGLContext.cpp?from=WebGLContext.cpp#331

Comment 1

[Walter Litwinczyk [:walter]]

Attachment: webgl_conformance_depth_stencil

Currently the fix fails on OSX 10.6:

https://tbpl.mozilla.org/?tree=Try&rev=b16ce8b87f1e

Comment 2

[Kelsey Gilbert [:jgilbert]]

This is fixed by bug 996266.

Comment 3

[u480271]

I also tried fixing this one.

Comment 4

[Kelsey Gilbert [:jgilbert]]

This should be fixed now that bug 996266 landed, but it looks like the test is still marked as failing on in one config. (It works for me only after this change)

Comment 5

[Kelsey Gilbert [:jgilbert]]

https://tbpl.mozilla.org/?tree=Try&rev=1d56c35df4b0

Comment 6

[Kelsey Gilbert [:jgilbert]]

Attachment: patch

It appears that this test file isn't used anymore, since changing whether this test should fail or not didn't fix or cause oranges on TBPL. This deserves more investigation.

Let's take this patch though.

Comment 7

[Kelsey Gilbert [:jgilbert]]

The current Windows test slaves all show:
> OpenGL renderer: ANGLE (NVIDIA GeForce GT 610 Direct3D9 vs_3_0 ps_3_0)

Comment 8

[Walter Litwinczyk [:walter]]

Comment on attachment 8481003 [details] [diff] [review]
patch

Looks good, try passes

Comment 9

[Kelsey Gilbert [:jgilbert]]

  https://hg.mozilla.org/integration/mozilla-inbound/rev/4f4da6284a48

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f4da6284a48

Comment 11

[Luke]

On Win 7 X1300, this test is still failing

https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-attributes-alpha-depth-stencil-antialias.html

FF 38.0a1 (2015-01-20)

FAIL gl.getParameter(gl.DEPTH_BITS) >= 16 should be true. Was false.
FAIL gl.getParameter(gl.STENCIL_BITS) >= 8 should be true. Was false.
FAIL gl.getParameter(gl.DEPTH_BITS) >= 16 should be true. Was false.
FAIL gl.getParameter(gl.STENCIL_BITS) >= 8 should be true. Was false.
FAIL gl.getParameter(gl.DEPTH_BITS) >= 16 should be true. Was false.

Chrome 42 Passes all tests.