Closed Bug 1024188 Opened 6 years ago Closed 6 years ago
Checks can be removed because Encoded
Frame::Swap In Frame Data() is infallible
This always returns NS_OK (presumably the SwapElements() used to be fallible?), but there are places like VP8TrackEncoder::GetEncodedPartitions() that check the return value for failure. Coverity noticed that if in fact this method failed, we would leak |videoData|, but it doesn't seem to understand NS_FAILED.
Component: Video/Audio → Video/Audio: Recording
Assignee: nobody → rlin
This patch removes useless check for using SwapInFrameData function.
Attachment #8470654 - Flags: review?(roc)
Attachment #8470654 - Flags: review?(roc) → review+
check-in patch, try result. https://tbpl.mozilla.org/?tree=Try&rev=19d83d9d1923
Attachment #8470654 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.