Closed Bug 1024188 Opened 6 years ago Closed 6 years ago

Checks can be removed because EncodedFrame::SwapInFrameData() is infallible

Categories

(Core :: Audio/Video: Recording, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: mccr8, Assigned: rlin)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 1168233])

Attachments

(1 file, 1 obsolete file)

This always returns NS_OK (presumably the SwapElements() used to be fallible?), but there are places like VP8TrackEncoder::GetEncodedPartitions() that check the return value for failure.  Coverity noticed that if in fact this method failed, we would leak |videoData|, but it doesn't seem to understand NS_FAILED.
Whiteboard: [CID 1168233]
Component: Video/Audio → Video/Audio: Recording
Assignee: nobody → rlin
Attached patch patch v1 (obsolete) — Splinter Review
This patch removes useless check for using SwapInFrameData function.
Attachment #8470654 - Flags: review?(roc)
Attachment #8470654 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/269d6f0e3c45
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.