1024188 - Checks can be removed because EncodedFrame::SwapInFrameData() is infallible

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[Andrew McCreight [:mccr8]]

This always returns NS_OK (presumably the SwapElements() used to be fallible?), but there are places like VP8TrackEncoder::GetEncodedPartitions() that check the return value for failure.  Coverity noticed that if in fact this method failed, we would leak |videoData|, but it doesn't seem to understand NS_FAILED.

Comment 1

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: patch v1

This patch removes useless check for using SwapInFrameData function.

Comment 2

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: check-in patch

check-in patch, try result.
https://tbpl.mozilla.org/?tree=Try&rev=19d83d9d1923

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/269d6f0e3c45

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/269d6f0e3c45