Closed
Bug 1024188
Opened 10 years ago
Closed 10 years ago
Checks can be removed because EncodedFrame::SwapInFrameData() is infallible
Categories
(Core :: Audio/Video: Recording, defect)
Core
Audio/Video: Recording
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: mccr8, Assigned: rlin)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 1168233])
Attachments
(1 file, 1 obsolete file)
4.42 KB,
patch
|
Details | Diff | Splinter Review |
This always returns NS_OK (presumably the SwapElements() used to be fallible?), but there are places like VP8TrackEncoder::GetEncodedPartitions() that check the return value for failure. Coverity noticed that if in fact this method failed, we would leak |videoData|, but it doesn't seem to understand NS_FAILED.
Reporter | ||
Updated•10 years ago
|
Whiteboard: [CID 1168233]
Assignee | ||
Updated•10 years ago
|
Component: Video/Audio → Video/Audio: Recording
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → rlin
Assignee | ||
Comment 1•10 years ago
|
||
This patch removes useless check for using SwapInFrameData function.
Attachment #8470654 -
Flags: review?(roc)
Attachment #8470654 -
Flags: review?(roc) → review+
Assignee | ||
Comment 2•10 years ago
|
||
check-in patch, try result. https://tbpl.mozilla.org/?tree=Try&rev=19d83d9d1923
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Attachment #8470654 -
Attachment is obsolete: true
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/269d6f0e3c45
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/269d6f0e3c45
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•