1024223 - PixmanTransform leaks |dest| and |src| if pixman_transform_invert returns false

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Andrew McCreight [:mccr8]]

pixman_image_t* dest = pixman_image_create_bits(aDest->Format() == gfxImageFormat::ARGB32 ? PIXMAN_a8r8g8b8 : PIXMAN_x8r8g8b8,
                                                  destSize.width,
                                                  destSize.height,
                                                  (uint32_t*)aDest->Data(),
                                                  aDest->Stride());
  ...
  pixman_image_t* src = pixman_image_create_bits(aSrc->GetFormat() == SurfaceFormat::B8G8R8A8 ? PIXMAN_a8r8g8b8 : PIXMAN_x8r8g8b8,
                                                 srcSize.width,
                                                 srcSize.height,
                                                 (uint32_t*)aSrc->GetData(),
                                                 aSrc->Stride());
  ...
  if (!pixman_transform_invert(&pixTransformInverted, &pixTransform)) {
    // src and dst leak
    return;
  }

Comment 1

[Andrew McCreight [:mccr8]]

http://mxr.mozilla.org/mozilla-central/source/gfx/layers/basic/BasicLayerManager.cpp#753

Note that BasicCompositor seems to have this same code, except it doesn't leak, so maybe all that is needed is to do the same thing:
  http://mxr.mozilla.org/mozilla-central/source/gfx/layers/basic/BasicCompositor.cpp#215

Comment 2

[Walter Litwinczyk [:walter]]

Attachment: skia_bug_1024223

Hi Andrew,

Would you mind seeing if this patch fixes the leak?

Comment 3

[Andrew McCreight [:mccr8]]

This is actually something detected by Coverity static analysis, so I don't have any way to check this myself, but I think based on comment 1 it should be okay, as I think Coverity didn't give a leak warning for the BasicCompositor.

Comment 4

[Walter Litwinczyk [:walter]]

Attachment: layer_leak_1024223

Comment 5

[Walter Litwinczyk [:walter]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=dca1d1c5f622
(ignore the misnaming)

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/23c1ad883992

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/23c1ad883992