Closed Bug 1024239 Opened 6 years ago Closed 6 years ago
[video] New menu on video is not localized
Bug 951025 added a new menu to video, but all the strings are hardcoded in English. We need to localize this feature for 2.0. PR incoming.
Assignee: nobody → tchevalier
Status: NEW → ASSIGNED
Attachment #8438815 - Flags: review?(johu)
Comment on attachment 8438815 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20393 Sorry, that's my fault. I should find that during the review process. Thanks for this patch.
Attachment #8438815 - Flags: review?(johu) → review+
Thanks for the quick review John
Would you please provide detail reproduce step for tester to verify this issue.Thanks!
Open a video, tap on the top right corner, you should see 3 strings properly translated on a localized build (Share, More info, Delete).
This issue has been successfully verified on Flame 2.0: Gaia-Rev 856863962362030174bae4e03d59c3ebbc182473 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/e40fe21e37f1 Build-ID 20141208000206 Version 32.0 Device-Name flame FW-Release 4.4.2 This issue has been successfully verified on Flame 2.1: Gaia-Rev 38e17b0219cbc50a4ad6f51101898f89e513a552 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a Build-ID 20141205001201 Version 34.0 Device-Name flame FW-Release 4.4.2
You need to log in before you can comment on or make changes to this bug.