Closed Bug 1024239 Opened 6 years ago Closed 6 years ago

[video] New menu on video is not localized

Categories

(Firefox OS Graveyard :: Gaia::Video, defect)

x86_64
Linux
defect
Not set

Tracking

(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S4 (20june)
blocking-b2g 2.0+
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: tchevalier, Assigned: tchevalier)

References

Details

(Keywords: late-l10n)

Attachments

(2 files)

Bug 951025 added a new menu to video, but all the strings are hardcoded in English. We need to localize this feature for 2.0.
PR incoming.
Blocks: 951025
Assignee: nobody → tchevalier
Status: NEW → ASSIGNED
Attachment #8438815 - Flags: review?(johu)
Comment on attachment 8438815 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20393

Sorry, that's my fault. I should find that during the review process. Thanks for this patch.
Attachment #8438815 - Flags: review?(johu) → review+
Thanks for the quick review John
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/4c3d7a868beb9b3be190b1068fc26da143407433
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S4 (20june)
blocking-b2g: 2.0? → 2.0+
Would you please provide detail reproduce step for tester to verify this issue.Thanks!
Flags: needinfo?(tchevalier)
Open a video, tap on the top right corner, you should see 3 strings properly translated on a localized build (Share, More info, Delete).
Flags: needinfo?(tchevalier)
Attached video VIDEO0158_Compress.MP4
This issue has been successfully verified on Flame 2.0:
Gaia-Rev        856863962362030174bae4e03d59c3ebbc182473
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/e40fe21e37f1
Build-ID        20141208000206
Version         32.0
Device-Name     flame
FW-Release      4.4.2

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.