1024360 - Remove deprecated mozIStorageBaseStatement methods usage from the tree

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Marco Bonardo [:mak]]

Some code in the tree is still using the deprecated mozIStorageBaseStatement methods:

bindUTF8StringParameter		
bindStringParameter		
bindDoubleParameter		
bindInt32Parameter		
bindInt64Parameter		
bindNullParameter
bindBlobParameter

http://mxr.mozilla.org/mozilla-central/search?string=bind%23Parameter\(&regexp=1

Comment 1

[Michael Pruett]

Attachment: Patch

This patch replaces usage of the deprecated methods on mozIStorageBaseStatement with mozIStorageBindingParams.bindByIndex().

Here are the results from the try server:
https://tbpl.mozilla.org/?tree=Try&rev=7b25bad55486

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8440491 [details] [diff] [review]
Patch

Review of attachment 8440491 [details] [diff] [review]:
-----------------------------------------------------------------

Hi, thanks for your contribution.
It looks good, but there are a couple things to figure:

1. You didn't replace the usage at http://mxr.mozilla.org/mozilla-central/source/dom/indexedDB/OpenDatabaseHelper.cpp#374 it should use BindXXXByName instead of these methods
1. on Try I see permanent failures on Windows. Off-hand they look unrelated, but still, would be safer to get a second try run (with also the cpp change) and verify that

Comment 3

[Michael Pruett]

Attachment: Patch

Thanks, Marco. I've updated the patch to replace the usage of BindXXXParameter() with BindXXXByIndex() in OpenDatabaseHelper.cpp.

And here are the results from the try server for this updated patch:
https://tbpl.mozilla.org/?tree=Try&rev=31e9437ccb9d

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8446581 [details] [diff] [review]
Patch

Review of attachment 8446581 [details] [diff] [review]:
-----------------------------------------------------------------

please add r=mak to checkin message

::: dom/indexedDB/OpenDatabaseHelper.cpp
@@ +378,3 @@
>      NS_ENSURE_SUCCESS(rv, rv);
>  
> +    rv = stmt->BindInt64ByIndex(2, dataVersion);

I'd prefer BindXXXByName in OpenDatabaseHelper.cpp, since the params are named in the query.

No need for a further Try, provided you can compile this code locally.

Comment 5

[Michael Pruett]

Attachment: Patch

I have changed BindXXXParameter() to BindXXXByName() rather than BindXXXByIndex() in OpenDatabaseHelper.cpp as you suggested.

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8447457 [details] [diff] [review]
Patch

Review of attachment 8447457 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good, thank you!

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/406d67967339

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/406d67967339