1024387 - [Collection App] Basic background support for Collection icons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Amir Nissim (:amirn)]

Collections icons are currently rendered background-less.

Background for collection icons were originally planned to be implemented in bug 1016221 which is currently blocked by build size issues of the system backgrounds.

This bug's scope is only for backgrounds for new collections to make sure it is part of 2.0

Comment 1

[Amir Nissim (:amirn)]

Attachment: PR

how to test:
1. create a new collection
2. notice it's icon has a background

Comment 2

[Kevin Grandon :kgrandon]

Let's be sure to block the collections app bug for anything we want to get into 2.0.

Comment 3

[Kevin Grandon :kgrandon]

Hey Guys - Looks like the patch is R+, has a green build, and looks great on a device. Hope you don't mind me landing it: https://github.com/mozilla-b2g/gaia/commit/d20c8ee7100891d6349d26f4e87fafcbd6254518

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8439061 [details] [review]
PR

This is a huge UX improvement for the vertical homescreen and is needed to ensure we don't have merge conflicts when uplifting. We've done our best job at testing this, and believe that this is safe for uplifting. Thanks!

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6ba6b0f74c7d

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/98b3cc733c0f883b9b1397b09372d5076ab4792c