1024433 - Displayed atom does not account for activityWindow

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Zac C (:zac)]

The atom does not take into account activityWindow, but it can also contain an app.

With a small change to the atom I think we can have it deal with these scenarios.

Comment 1

[Zac C (:zac)]

Attachment: github pr

Comment 2

[Zac C (:zac)]

Sorry Dave my original comment was a bit vague.. 

An app can load another app inside an activityWindow. In that case the atom returns the underlying app but that is not the one in focus to the user.
This variation will return the app that's in focus to the user.

This structure of this is best observed from the App Manager using a Collection installed with everything.me.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8439178 [details] [review]
github pr

This looks okay to me, but might be worth asking Alive to take a look too.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8439178 [details] [review]
github pr

var activeTop = app;
while (activeTop.frontWindow && activeTop.frontWindow.isActive()) {
  activeTop = activeTop.frontWindow;
}
return activeTop;

I guess one day I will put this in AppWindow but for now you need to manually find the active most top one.

Comment 5

[Zac C (:zac)]

Thanks Alive, superstar!

Comment 6

[Zac C (:zac)]

Adhoc job with Alive's change:
http://selenium.qa.mtv2.mozilla.com:8080/job/b2g.flame.mozilla-central.ui.adhoc/28

(I verified the unit tests locally).

Comment 7

[Zac C (:zac)]

Comment on attachment 8439178 [details] [review]
github pr

Modified to use Alive's snippet.

Comment 8

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/83392cae2c964fa6f8a97ac3fc515c3f94ef3c1c