1024459 - Define an out of line destructor for TextTrack so that we can forward delcare HTMLTrackElement in TextTrack.h

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

I have no idea how MSVC manages to compile this, this code is clearly incorrect!

Comment 1

[(no longer active)]

Attachment: Define an out of line destructor for TextTrack so that we can forward delcare HTMLTrackElement in TextTrack.h

This is required because the destructor for the nsRefPtr<HTMLTrackElement>
member requires the full definition of the type.

Comment 2

[(no longer active)]

(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #0)
> I have no idea how MSVC manages to compile this, this code is clearly
> incorrect!

Presumably because HTMLTrackElement.h ends up being included by other things... :(

Comment 3

[(no longer active)]

Ping?  :-)  This should be very similar to the other patches like this.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8439173 [details] [diff] [review]
Define an out of line destructor for TextTrack so that we can forward delcare HTMLTrackElement in TextTrack.h

Er, I thought I'd stamped this one...

r=me

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b53ab3070ee8

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b53ab3070ee8