Closed Bug 1024535 Opened 10 years ago Closed 10 years ago

Perma-failing Windows 7 opt test_load_candidates.html | Error events on source children should not bubble

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34
Tracking Flags:
Tracking Status
firefox32 --- fixed
firefox33 --- fixed
firefox34 --- fixed
firefox-esr24 --- unaffected
firefox-esr31 --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: emorley, Assigned: martijn.martijn)

References

(
URL
)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

1024535.diff (for check-in)
1.55 KB, patch
jwwang
: review+
Details | Diff | Splinter Review 
Windows 7 32-bit mozilla-central opt test mochitest-1 on 2014-05-28 22:39:07 PDT for push c8252fd40ba7

slave: t-w732-ix-107

https://tbpl.mozilla.org/php/getParsedLog.php?id=40609834&tree=Mozilla-Central

{
22:53:55     INFO -  5734 INFO TEST-START | /tests/content/media/test/test_load_candidates.html
22:53:58     INFO -  5735 INFO TEST-INFO | MEMORY STAT vsize after test: 1056215040
22:53:58     INFO -  5736 INFO TEST-INFO | MEMORY STAT vsizeMaxContiguous after test: 577306624
22:53:58     INFO -  5737 INFO TEST-INFO | MEMORY STAT residentFast after test: 199421952
22:53:58     INFO -  5738 INFO TEST-INFO | MEMORY STAT heapAllocated after test: 76081992
22:53:58     INFO -  5739 INFO TEST-END | /tests/content/media/test/test_load_candidates.html | finished in 2265ms
22:53:58     INFO -  5740 INFO TEST-INFO | dumping last 33 message(s)
22:53:58     INFO -  5741 INFO TEST-INFO | if you need more context, please use SimpleTest.requestCompleteLog() in your test
22:53:58     INFO -  5742 INFO TEST-INFO | /tests/content/media/test/test_load_candidates.html | Started Wed May 28 2014 22:53:56 GMT-0700 (Pacific Standard Time) (1401342836.107s)
22:53:58     INFO -  5743 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [started small-shot.ogg-0] Length of array should match number of running tests
22:53:58     INFO -  5744 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [started small-shot.m4a-1] Length of array should match number of running tests
22:53:58     INFO -  5745 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | Should have received 2 error events before loaded
22:53:58     INFO -  5746 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [finished small-shot.m4a-1] Length of array should match number of running tests
22:53:58     INFO -  5747 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [started small-shot.mp3-2] Length of array should match number of running tests
22:53:58     INFO -  5748 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | Should have received 2 error events before loaded
22:53:58     INFO -  5749 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [finished small-shot.ogg-0] Length of array should match number of running tests
22:53:58     INFO -  5750 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [started small-shot-mp3.mp4-3] Length of array should match number of running tests
22:53:58     INFO -  5751 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | Should have received 2 error events before loaded
22:53:58     INFO -  5752 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [finished small-shot.mp3-2] Length of array should match number of running tests
22:53:58     INFO -  5753 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [started r11025_s16_c1.wav-4] Length of array should match number of running tests
22:53:58     INFO -  5754 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | Should have received 2 error events before loaded
22:53:58     INFO -  5755 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [finished small-shot-mp3.mp4-3] Length of array should match number of running tests
22:53:58     INFO -  5756 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [started 320x240.ogv-5] Length of array should match number of running tests
22:53:58     INFO -  5757 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | Should have received 2 error events before loaded
22:53:58     INFO -  5758 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [finished r11025_s16_c1.wav-4] Length of array should match number of running tests
22:53:58     INFO -  5759 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [started seek.webm-6] Length of array should match number of running tests
22:53:58     INFO -  5760 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | Should have received 2 error events before loaded
22:53:58     INFO -  5761 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [finished 320x240.ogv-5] Length of array should match number of running tests
22:53:58     INFO -  5762 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [started vp9.webm-7] Length of array should match number of running tests
22:53:58     INFO -  5763 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | Should have received 2 error events before loaded
22:53:58     INFO -  5764 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [finished seek.webm-6] Length of array should match number of running tests
22:53:58     INFO -  5765 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [started detodos.opus-8] Length of array should match number of running tests
22:53:58     INFO -  5766 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | Should have received 2 error events before loaded
22:53:58     INFO -  5767 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [finished vp9.webm-7] Length of array should match number of running tests
22:53:58     INFO -  5768 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [started gizmo.mp4-9] Length of array should match number of running tests
22:53:58     INFO -  5769 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | Should have received 2 error events before loaded
22:53:58     INFO -  5770 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [finished detodos.opus-8] Length of array should match number of running tests
22:53:58     INFO -  5771 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | Should have received 2 error events before loaded
22:53:58     INFO -  5772 INFO TEST-PASS | /tests/content/media/test/test_load_candidates.html | [finished gizmo.mp4-9] Length of array should match number of running tests
22:53:58     INFO -  5773 INFO TEST-INFO | /tests/content/media/test/test_load_candidates.html | Finished at Wed May 28 2014 22:53:58 GMT-0700 (Pacific Standard Time) (1401342838.173s)
22:53:58     INFO -  5774 INFO TEST-INFO | /tests/content/media/test/test_load_candidates.html | Running time: 2.066s
22:53:58     INFO -  5775 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_load_candidates.html | Error events on source children should not bubble
}
https://tbpl.mozilla.org/php/getParsedLog.php?id=41587504&tree=Mozilla-Inbound
Windows 7 32-bit mozilla-inbound opt test mochitest-1 on 2014-06-12 01:14:20
revision: 47bf0d6847e4
slave: t-w732-ix-118

5918 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_load_candidates.html | Error events on source children should not bubble
6342 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_streams_element_capture.html | detodos.opus checking readyState - got 4, expected 2
Return code: 1
This seems to occur at the same time as bug 750258.

https://tbpl.mozilla.org/php/getParsedLog.php?id=41603853&tree=Mozilla-Inbound
See Also: → 750258
Blocks: 1032878
(In reply to Ed Morley [:edmorley UTC+0] from comment #2)
> This seems to occur at the same time as bug 750258.
> 
> https://tbpl.mozilla.org/php/getParsedLog.php?id=41603853&tree=Mozilla-
> Inbound

Sigh, ok it seems as though test_load_candidates.html is perma-orange on *all* Windows 7 opt runs (not debug and not any other Windows version), it just doesn't make the run fail on it's own - so we only see the failures when something else also fails in the run. 

Have filed bug 1032878 for fixing the harness not to miss this - but we'll still need to fix the failures in this test, otherwise when bug 1032878 lands we'll turn the tree orange permanently for Win7 opt mochitest-1.

The earliest instance I can see for this is in bug 750258 comment 376 at 2014-05-28 22:39:07 PT
See Also: 750258 →
Summary: Intermittent test_load_candidates.html | Error events on source children should not bubble → Perma-failing Windows 7 opt test_load_candidates.html | Error events on source children should not bubble
On the plus side, since this is perma-failing on Win7 opt, it should be easy to repro on Try :-)
This fixes the test for me on Windows 7, tested on Windows 7 and MacOS X.
Note that on MacOS X, I see 21 results counted, while on Windows 7, I see 27 results counted.
Assignee: nobody → martijn.martijn
Attachment #8471954 - Flags: review?(jwwang)
Comment on attachment 8471954 [details] [diff] [review]
1024535.diff (for check-in)

Review of attachment 8471954 [details] [diff] [review]:
-----------------------------------------------------------------

This seems to defeat the purpose of this test where we want to test the error events in source children will not bubble. It is also suspicious to happen on Windows only. Can you find out where the unexpected error event comes from before we know it is safe to remove the error event handler?
Attachment #8471954 - Flags: review?(jwwang)
(In reply to JW Wang [:jwwang] from comment #54)
> Comment on attachment 8471954 [details] [diff] [review]
> This seems to defeat the purpose of this test where we want to test the
> error events in source children will not bubble. It is also suspicious to
> happen on Windows only. Can you find out where the unexpected error event
> comes from before we know it is safe to remove the error event handler?

This error event is fired when the mochitest document gets unloaded. That's not the time when subtest results should be logging. Once bug 1032878 is fixed, this would cause tbpl to go orange for Windows 7 mochitest.
So either this has to be fixed in some way or this test has to be disabled for Windows 7.
I don't know how to fix it from the backend side, so that's why I tried to hide this issue by changing the test.
Should we disable this test for Windows 7 instead?
Flags: needinfo?(jwwang)
(In reply to Martijn Wargers [:mwargers] (QA) from comment #57)
> This error event is fired when the mochitest document gets unloaded.

If that is the case, I am fine with removing the error event handler at the end of the test. However, I am still wondering why this happens on Windows 7 only. The error event triggered during document unload should happen on all platforms.
Flags: needinfo?(jwwang)
Comment on attachment 8471954 [details] [diff] [review]
1024535.diff (for check-in)

Review of attachment 8471954 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to JW Wang [:jwwang] from comment #58)
> (In reply to Martijn Wargers [:mwargers] (QA) from comment #57)
> > This error event is fired when the mochitest document gets unloaded.
> 
> If that is the case, I am fine with removing the error event handler at the
> end of the test. However, I am still wondering why this happens on Windows 7
> only. The error event triggered during document unload should happen on all
> platforms.

Thanks! Can you r+ this patch then?

I can file a new bug on this error event issue and write a new mochitest for it.
Attachment #8471954 - Flags: review?(jwwang)
Comment on attachment 8471954 [details] [diff] [review]
1024535.diff (for check-in)

Review of attachment 8471954 [details] [diff] [review]:
-----------------------------------------------------------------

OK. Please file another bug to investigate the mysterious error event during unloading document which happens on Windows 7 only.
Attachment #8471954 - Flags: review?(jwwang) → review+
Tryserver from comment 62 looks very orange, but that is because I combined with other patches. The test file this patch is touching, is fixed by this change.
(In reply to JW Wang [:jwwang] from comment #61)

> OK. Please file another bug to investigate the mysterious error event during
> unloading document which happens on Windows 7 only.

Filed bug 1055579.
Attachment #8471954 - Attachment description: 1024535.diff → 1024535.diff (for check-in)
https://hg.mozilla.org/mozilla-central/rev/b34273fcfa44
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: