Closed Bug 1024678 Opened 6 years ago Closed 6 years ago
Avoid using xmm registers in regexp code
Floating point registers can't be accessed if the JIT does not support them. While irregexp never accesses these registers, when external calls are made all volatile registers are pushed, including these registers.
Attachment #8439426 - Flags: review?(jdemooij)
Attachment #8439426 - Flags: review?(jdemooij) → review+
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Is this fix going to be pushed down to Aurora 32.0a2? It looks like crashes I had in Nightly 32.0a1 [involving js::irregexp (e.g. bug #1013586), which were fixed with this patch (Bug) landing], are now occurring in Aurora 32.0a2. Or, is there a different bug# I should follow for this fix being applied to Aurora?
Comment on attachment 8439426 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 976446 User impact if declined: crashes on older CPUs Testing completed (on m-c, etc.): on m-c Risk to taking this patch (and alternatives if risky): none
Attachment #8439426 - Flags: approval-mozilla-aurora?
Comment on attachment 8439426 [details] [diff] [review] patch Not serious enough to track, but uplift is low risk and helps with crashes so approving.
Attachment #8439426 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.