1024847 - [Settings] Remove battery.js from the list of lazy loading

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

As root panel has been refactored as an AMD module, the battery module should also be required in the AMD way.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/20480

EJ, could you help review this simple patch? It simply converts the legacy script to an AMD module and updates some dom namings. Thanks!

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8439737 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/20480

r+ with only one nit.

But because there are some changes in python, that would be better to ask for Zac or some others' review for that.

And please make sure to merge your patch after Travis is green.

Thanks for your efforts, Arthur :)

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8439737 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/20480

Thanks for reviewing, EJ!

Zac, as I modified the id of an element, could you help review the follwing ui test files? Thanks!

tests/python/gaia-ui-tests/gaiatest/apps/settings/app.py
tests/python/gaia-ui-tests/gaiatest/tests/endurance/test_endurance_settings.py

Comment 4

[Zac C (:zac)]

Comment on attachment 8439737 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/20480

Looks fine to me, r+

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for reviewing.

master: 3eba4be4ddc442d5f8da9d8600903979ff776c1a