1024863 - Safeguard against potential race condition

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Kevin Grandon :kgrandon]

Lucas handed me his phone earlier to debug a weird problem where there were multiple duplicates of apps. I'm not sure how he generated them, but I noticed an error message in the log.

E/GeckoConsole(23057): [JavaScript Error: "TypeError: appObject is undefined" {file: "app://verticalhome.gaiamobile.org/js/sources/bookmark.js" line: 135}]

This would prevent our auto-cleaner from running, so we should safeguard that (so at least invalid results can go away)

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Review-stamp anyone? :)

Comment 2

[James Lal [:lightsofapollo]]

Comment on attachment 8439699 [details] [review]
Github pull request

Gave my comments in person.. if we land this lets land it will logging (+ stack ideally) so we can figure out which items this is happening to and where the add was called from so we can fix the real issue rather then just work around it.

Comment 3

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/a9d2f30ada94dd828ea9a34257d6ca213a37ba78

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8439699 [details] [review]
Github pull request

This is required for the vertical homescreen. It's been baking on master for several days and should be safe to uplift. Thanks!

Comment 5

[Kevin Grandon :kgrandon]

Uplfited: https://github.com/mozilla-b2g/gaia/commit/eda7b141f6967738b42c0f11768d94ed4398b58f