1024882 - [Window Management] Copy-paste gaia changes since gecko api update

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

We need to modify gaia due to gecko api change for copy-paste.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Morris,
could you check this patch first if it meets latest API update?
Thanks.

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8439735 [details] [review]
PR to master

looks good to me!! Thank you.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8439735 [details] [review]
PR to master

Hi Alive,
I've modified part of gaia due to gecko api changes.
Please kindly check this patch.
Thanks.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8439735 [details] [review]
PR to master

Please move the this.app.iframe.XXXX to browser_mixin.js

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Morris,
do we have document for doCommand api?
Thanks

Comment 6

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

We don't have document for that api right now. But you can check bug 987040 comment 33, there is some api information.

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
set dependency on bug 987040.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Target milestone move to next sprint since the API might change again.

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

I will also change the order of selection option from 
"copy cut paste selectAll" to "select all, cut, copy, paste".

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

clear target milestone since bug 987040 is not fixed yet.

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

PR has been updated , however, current pvt doesn't have complete bug 987040, so I set its target date to next sprint.

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

We also need to concern the interaction with Keyboard.
For example,
when we select all and cut, what should be showed in suggestion bar?
I will prepare a phone with copy-paste enalbed for UX to clarify.

Comment 13

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8439735 [details] [review]
PR to master

Hi Alive and Morris,
could you guys check my patch? It's based on latest API change.
Changes are as below

1. we only listen to mozChromEvent to handle dialog's position and displaying, since gecko will manage all mozBrowser through shell.js.
2. update unit tests.

Comment 14

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8439735 [details] [review]
PR to master

Looks good to me, I leave some comments at PR.

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8439735 [details] [review]
PR to master

Looks like the mozbrowser event are gong for some reason, though I expect I am told why but basically the code looks fine.

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

Since the dialog is not per window now, please make sure when doing swipe navigation it disappears right away. Also I would like to propose to use another event other than mozChromeEvent.

Comment 17

[(Inactive after June) George Duan [:gduan] [:喬智]]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #15)
> Comment on attachment 8439735 [details] [review]
> PR to master
> 
> Looks like the mozbrowser event are gong for some reason, though I expect I
> am told why but basically the code looks fine.

Comments from shell.js,
 // The mozbrowserselectionchange event, may have crossed the chrome-content boundary.
 // This event always dispatch to shell.js. But the offset we got from this event is
 // based on tab's coordinate. So get the actual offsets between shell and evt.target.

Comment 18

[(Inactive after June) George Duan [:gduan] [:喬智]]

(In reply to George Duan [:gduan] [:喬智] from comment #9)
> I will also change the order of selection option from 
> "copy cut paste selectAll" to "select all, cut, copy, paste".

I forgot to change the order like above.

Comment 19

[(Inactive after June) George Duan [:gduan] [:喬智]]

I tried to remove press method in marionette, however, it has some problem to pass the position of dialog. So I file  bug 1049367 for it.

Comment 20

[(Inactive after June) George Duan [:gduan] [:喬智]]

Travis passed,
https://tbpl.mozilla.org/?tree=Gaia-Try&rev=5c1a1ebcebb9


Merge to master
https://github.com/mozilla-b2g/gaia/commit/bea8355ea0c48de3a55c8cc59854f91cf2561b4a