1024887 - [Settings] Move the code of loading language descriptions to a separate module

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

As root panel has been refactored as an AMD module, the code for supporting the language item should be moved to a separate module.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/20483

EJ, the patch is similar to the battery patch, could you help review it? Thanks!

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8439758 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/20483

Zac, as I modified the id of an element, could you help review the follwing ui test files? Thanks!

tests/python/gaia-ui-tests/gaiatest/apps/settings/app.py
tests/python/gaia-ui-tests/gaiatest/tests/endurance/test_endurance_settings.py

Comment 3

[Zac C (:zac)]

Comment on attachment 8439758 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/20483

r+ the locator changes.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Arthur, the code is neat and looks nice to me ! 

Just left few comments on Github and please go ahead and check it ! 

Thanks :P

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for reviewing, EJ! I've addressed your comment by adding a line requiring `utils`, please have a look again.

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8439758 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/20483

Thanks Arthur :)

r+

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: 5f8dce8a23b6489690719dfaa51d1b81823c3b4b