1024899 - After update from v 29.0.1 to v 30.0 the site: https://home.cgm-life.de/fb363286-e393-4a31-84c1-9c60e07c6cef cannot be reached (responsive design - twitter bootstrap - Angular JS)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[stefan.olschewski]

Attachment: before after.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140605174243

Steps to reproduce:

After update from Firefox v 29.0.1 to v 30.0 I tried to open the following web application:

https://home.cgm-life.de/fb363286-e393-4a31-84c1-9c60e07c6cef




Actual results:

With v 29.0.1 the content was displayed correct, with v 30.0 only the background is loaded.


Expected results:

The page should be depicted the same way with v 30.0 like with v 29.0.1 (or prior versions.)

We do use responsive-design with "Twitter Bootstrap", the application is build with AngularJS.

The application worked with several previous versions of Firefox properly.

Comment 1

[YF (Yang)]

for https://home.cgm-life.de/fb363286-e393-4a31-84c1-9c60e07c6cef.
Fx30.0 got "TypeError: console is undefined" at portal:338 and the blank page.
Fx31b1 & 32a1 is works fine.
Upcoming fix?

Comment 2

[(mostly gone) XtC4UaLL [:xtc4uall]]

Console says:
TypeError: console is undefined


    console.log(l_lang);
    document.write('<script src="components/angular-i18n/angular-locale_' + angular.lowercase(l_lang) + '.js"><\/script>');

    angular.element(document).ready(function ()
    {
        angular.bootstrap(document, ['cgmApp']);
        // Fix to run E2E tests. This is a known issue
        document.body.setAttribute('ng-app', 'App');
    });

-> related to bug 965860/Bug 1024806?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yes.  The script on https://home.cgm-life.de/fb363286-e393-4a31-84c1-9c60e07c6cef has this bit at toplevel, with some parts elided:

    if (navigator.userLanguage) // Explorer
    {
        l_lang = navigator.userLanguage;
        var console = {
           // stuff here to have a log function, etc
        };
    }
    else if (navigator.language) // FF
    {
        l_lang = navigator.language;
    }
    else {
        l_lang = "en-us";
    }

Since this is not inside a function and var declarations are hoisted, this ends up shadowing window.console with "undefined".

So really, the same thing as bug 1024806 but on a different site.

Comment 4

[Boris Zbarsky [:bzbarsky]]

To be clear, this is directly on the page, not in any of the libraries it loads, in terms of how widespread that sort of thing would be.

Comment 5

[Boris Zbarsky [:bzbarsky]]

OK, but this IS an issue for b2g30, so we may want a fix there.

Comment 6

[Kohei Yoshino]

Added to the site compat doc:
https://developer.mozilla.org/en-US/Firefox/Releases/30/Site_Compatibility#JavaScript

Comment 7

[stefan.olschewski]

Can we do some code-changes on our site to get it working with v 30.0?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Yes!  Change the code in comment 3 to use "window.console = { stuff }" instead of "var console = { stuff }".  Then you will only change the value of window.console in browsers that have navigator.userLanguage, which is what you're probably aiming for.

Or better yet, only change window.console if !window.console instead of coupling it to the userLanguage stuff.

Comment 9

[Boris Zbarsky [:bzbarsky]]

So basically:

  if (!window.console) {
    window.console = { stuff };
  }

Comment 10

[stefan.olschewski]

Thank you very much.
Do you know a concrete date when a bugfix for v 30.0 will be delivered?

Comment 11

[Boris Zbarsky [:bzbarsky]]

When 31 ships, in about 4.5 weeks.

Comment 12

[Boris Zbarsky [:bzbarsky]]

More precisely, the bugfix will be to upgrade to 31.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Since there is a site workaround, this is not a driver for a 30 chemspill and we'll see the fix ship in 31.

Comment 14

[Andrew Overholt [:overholt]]

Ritu, what flags do we need to set to note when this was fixed?