[Messages] Activity Handler tests are failing with newer mocha

RESOLVED FIXED in 2.0 S4 (20june)

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: julienw, Assigned: julienw)

Tracking

unspecified
2.0 S4 (20june)
x86_64
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [not-part-of-initial-sprint])

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
azasypkin
: review+
Details | Review | Splinter Review
(Assignee)

Description

5 years ago
There is a race condition in the tests made in bug 1007591.
(Assignee)

Comment 1

5 years ago
Created attachment 8439844 [details] [review]
github PR

To test it, you need to checkout the branch in bug 874510 (rebased with a recent master, maybe not latest though) and apply this patch on top.

But the race is here on master too and I think it could be a rare intermittent even with the current mocha.
Attachment #8439844 - Flags: review?(azasypkin)
Comment on attachment 8439844 [details] [review]
github PR

Works great!

Thanks!
Attachment #8439844 - Flags: review?(azasypkin) → review+
(Assignee)

Comment 3

5 years ago
master: 012117784d9bbc2901e27adcbaee7bf5a71e0707
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Blocks: 1022706
Whiteboard: [not-part-of-initial-sprint]
(Assignee)

Updated

5 years ago
Target Milestone: --- → 2.0 S4 (20june)
You need to log in before you can comment on or make changes to this bug.