Closed Bug 1024978 Opened 6 years ago Closed 6 years ago

[Messages] Activity Handler tests are failing with newer mocha

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S4 (20june)

People

(Reporter: julienw, Assigned: julienw)

References

Details

(Whiteboard: [not-part-of-initial-sprint])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
azasypkin
: review+
Details | Review
There is a race condition in the tests made in bug 1007591.
Attached file github PR
To test it, you need to checkout the branch in bug 874510 (rebased with a recent master, maybe not latest though) and apply this patch on top.

But the race is here on master too and I think it could be a rare intermittent even with the current mocha.
Attachment #8439844 - Flags: review?(azasypkin)
Comment on attachment 8439844 [details] [review]
github PR

Works great!

Thanks!
Attachment #8439844 - Flags: review?(azasypkin) → review+
master: 012117784d9bbc2901e27adcbaee7bf5a71e0707
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: sms-sprint-3
Whiteboard: [not-part-of-initial-sprint]
Target Milestone: --- → 2.0 S4 (20june)
You need to log in before you can comment on or make changes to this bug.