Closed Bug 1025022 Opened 7 years ago Closed 7 years ago

Pass T* to nsCOMArray::Contains

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file)

It takes nsISupports* now, which is somewhat silly; in particular, it doesn't actually do full COM comparisons, like ContainsObject, so passing something that isn't a T* is most likely a bug.
Comment on attachment 8439913 [details] [diff] [review]
Pass T* to nsCOMArray::Contains

ContainsObject probably needs the same treatment (compare IndexOfObject which was a pre-existing method on nsCOMArray).
Attachment #8439913 - Flags: review?(neil) → review+
https://hg.mozilla.org/mozilla-central/rev/9f36a2af44b1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.