[Vertical Homescreen] Rocketbar appears in edit mode when overscrolling

VERIFIED FIXED in Firefox OS v2.0

Status

Firefox OS
Gaia::Homescreen
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: jlorenzo, Assigned: kgrandon)

Tracking

unspecified
2.0 S4 (20june)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 verified)

Details

(Whiteboard: [systemsfe])

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Steps to reproduce
1. Enter edit mode
2. Scroll up to overscroll

Expected result
Edit header should also overscoll to hide Rocketbar

Actual result
The header is moving but does not follow the scroll move. Hence, Rocketbar is displayed during overscroll.
(Reporter)

Comment 1

4 years ago
Need info from UX to tell if it's a blocker for 2.0 feature complete or not.
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking?]
Flags: needinfo?(jsavory)
(Assignee)

Comment 2

4 years ago
We can probably fix this in 2.1, unlikely that we will be able to fix this in 2.0.
I would actually consider this one a blocker. 
I feel that it looks really bad and is quite obvious while scrolling in edit mode. There is also a possibility that the user might think its broken and that they should be able to use the rocketbar in edit mode.
Flags: needinfo?(jsavory)
(Reporter)

Updated

4 years ago
blocking-b2g: --- → 2.0?
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking?] → [VH-FL-blocking-][VH-FC-blocking+]
(Assignee)

Comment 4

4 years ago
Jacqueline - Would we be ok with solving this in edit mode by hiding the rocketbar, and still having it detach on overscroll when not in edit mode? In 2.0 that's probably the only solution we have while keeping overscrolling.
Flags: needinfo?(jsavory)
(Assignee)

Updated

4 years ago
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
(Assignee)

Comment 5

4 years ago
Right - this bug was reported specifically about edit mode, so I suppose that's what we're concerned about for now. I'll submit a patch.
Flags: needinfo?(jsavory)
(Assignee)

Comment 6

4 years ago
Created attachment 8440353 [details] [review]
Github pull request

This is a one-liner css change, so R=me.
Attachment #8440353 - Flags: review+
(Assignee)

Updated

4 years ago
Blocks: 989848
No longer blocks: 1017954
(Assignee)

Comment 7

4 years ago
Landed: https://github.com/mozilla-b2g/gaia/commit/0b0d0440503dbb3e0329c57a06393fa04387588d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
blocking-b2g: 2.0? → 2.0+
(Reporter)

Comment 8

4 years ago
Verified on master.
Status: RESOLVED → VERIFIED
v2.0: https://github.com/mozilla-b2g/gaia/commit/a5de0c5e472a51c9f63e95c13c3e943380c1f4d0
status-b2g-v2.0: --- → fixed
status-b2g-v2.1: --- → fixed
Target Milestone: --- → 2.0 S4 (20june)
Whiteboard: [systemsfe]

Updated

3 years ago
status-b2g-v2.0: fixed → verified
status-b2g-v2.1: fixed → verified

Comment 10

3 years ago
Created attachment 8530718 [details]
VIDEO0078.mp4

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2


This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
You need to log in before you can comment on or make changes to this bug.