1025196 - [Vertical Homescreen] Rocketbar appears in edit mode when overscrolling

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Steps to reproduce
1. Enter edit mode
2. Scroll up to overscroll

Expected result
Edit header should also overscoll to hide Rocketbar

Actual result
The header is moving but does not follow the scroll move. Hence, Rocketbar is displayed during overscroll.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Need info from UX to tell if it's a blocker for 2.0 feature complete or not.

Comment 2

[Kevin Grandon :kgrandon]

We can probably fix this in 2.1, unlikely that we will be able to fix this in 2.0.

Comment 3

[Jacqueline Savory [:jsavory] UX]

I would actually consider this one a blocker. 
I feel that it looks really bad and is quite obvious while scrolling in edit mode. There is also a possibility that the user might think its broken and that they should be able to use the rocketbar in edit mode.

Comment 4

[Kevin Grandon :kgrandon]

Jacqueline - Would we be ok with solving this in edit mode by hiding the rocketbar, and still having it detach on overscroll when not in edit mode? In 2.0 that's probably the only solution we have while keeping overscrolling.

Comment 5

[Kevin Grandon :kgrandon]

Right - this bug was reported specifically about edit mode, so I suppose that's what we're concerned about for now. I'll submit a patch.

Comment 6

[Kevin Grandon :kgrandon]

Attachment: Github pull request

This is a one-liner css change, so R=me.

Comment 7

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/0b0d0440503dbb3e0329c57a06393fa04387588d

Comment 8

[Johan Lorenzo [:jlorenzo]]

Verified on master.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/a5de0c5e472a51c9f63e95c13c3e943380c1f4d0

Comment 10

[Elie]

Attachment: VIDEO0078.mp4

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2


This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2