Closed Bug 1025240 Opened 10 years ago Closed 10 years ago

test-native-options should cleanup the preference branches that it creates

Categories

(Add-on SDK Graveyard :: General, defect)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: evold, Assigned: evold)

References

Details

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1514
46 bytes, text/x-github-pull-request
zombie
: review+
Details | Review
The test-native-options.js file contains tests which create default pref branches and these tests do not clean up after themselves when they are done.
Assignee: nobody → evold
Comment on attachment 8440102 [details] [review] Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1514 r+ without the changes to `testNoPrefs` which: 1) render that test ineffective, and 2) are not even needed to "fix" this bug, imho. details in the PR comment.
Attachment #8440102 - Flags: review?(tomica+amo) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/8ac4fd19e5a8c086fd4e76fed757b4ca5cbd8ac5 Bug 1025240 - test-native-options should cleanup the preference branches that it creates https://github.com/mozilla/addon-sdk/commit/7ce9ee0cf3c6ebd72661551878e2675c4f7fe55b Merge pull request #1514 from erikvold/1025240 Bug 1025240 - test-native-options should cleanup the preference branches that it creates r=@zombie
Depends on: 1024837
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: