1025309 - FxA does not fire onlogout for FMD

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FxA, defect, P2)

Description

[Sam Penrose]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1000323#c18 :

"STR:
1) Go to Settings > Firefox Accounts
2) Log in
3) Go back, enter Find My Device, notice how it properly shows the Enable/Disable switch
4) Go back to Firefox Accounts
5) Log out
6) Go back to Find My Device, notice how it still shows the Enable/Disable switch

In step 6, we should see the login button in FMD, which is displayed when onlogout fires. Also, FMD logs a message to the console whenever onlogin/onlogout fires, and that message is not logged for logout -- which further indicates that onlogout is not being fired.

Note, however, that if you close the Settings app, reopen it and go to Find My Device, that will cause a new call to navigator.mozId.request() to be made, which successfully fires onlogout then."

Comment 1

[Sam Penrose]

Attachment: 1025309-onlgout-fmd.patch

Hi Jed: a simple patch to add a missing event volley. Thanks!

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Comment on attachment 8441123 [details] [diff] [review]
1025309-onlgout-fmd.patch

Review of attachment 8441123 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!  Thanks, Sam.

Comment 3

[Sam Penrose]

Attachment: 1025309-onlgout-fmd.patch

https://tbpl.mozilla.org/?tree=Try&rev=685731972f01

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/1d2f78d76197

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1d2f78d76197

Comment 6

[Sam Penrose]

Comment on attachment 8441531 [details] [diff] [review]
1025309-onlgout-fmd.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): [this bug]
User impact if declined: weakened FMD security, Marketplace functionality
Testing completed (on m-c, etc.): 
https://tbpl.mozilla.org/?tree=Try&rev=685731972f01
Risk to taking this patch (and alternatives if risky): unanticipated bugs
String or IDL/UUID changes made by this patch:None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f5d13392d3db

Comment 8

[Elie]

Attachment: VIDEO0141.mp4

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        3aa0797c111a40e36f722722309668de3d469181
Gecko-Rev       93efc8b4155f0a4a50eaad19acbb95ec24139e63
Build-ID        20141204050313
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0
Device-Name     flame
FW-Release      4.4.2