Closed
Bug 1025354
Opened 11 years ago
Closed 11 years ago
Out of bounds read in cc_src_name
Categories
(Core :: WebRTC: Signaling, defect)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: erahm, Assigned: jesup)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 749132])
Attachments
(1 file)
|
964 bytes,
patch
|
ehugg
:
review+
|
Details | Diff | Splinter Review |
It looks like cc_srcs_t[1] is out of sync with cc_src_names[2].
[1] http://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/sipcc/core/includes/ccapi.h?from=ccapi.h&case=true#304
[2] http://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/sipcc/core/includes/ccapi.h?from=ccapi.h&case=true#304
|
Reporter | |
Updated•11 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
|
Assignee | |
Comment 1•11 years ago
|
||
Probably we don't generate logs with CC_SRC_CCAPP, given how we use SIPCC, but I can't say that for certain and it's trivial to patch.
Assignee: nobody → ethanhugg
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Assignee: ethanhugg → rjesup
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8440214 -
Flags: review?(ethanhugg)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8440214 [details] [diff] [review]
fix out-of-sync name array for SIPCC logs
Review of attachment 8440214 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #8440214 -
Flags: review?(ethanhugg) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Target Milestone: --- → mozilla33
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•