Closed
Bug 1025491
Opened 10 years ago
Closed 10 years ago
Remove the DumpAsPNG() code in FilterNodeSoftware.cpp
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file)
|
2.89 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
The DumpAsPNG() code in FilterNodeSoftware.cpp is redundant since we now have gfxUtils::DumpAsDataURL.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8440292 -
Flags: review?(mstange)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8440292 [details] [diff] [review] patch The gfxUtils.h #include needs to be #ifdef'd to DEBUG_DUMP_SURFACES because gfxUtils.h is not part of Moz2D (but FilterNodeSoftware.cpp is). It's a hack, but having DEBUG_DUMP_SURFACES working in Moz2D-in-mozilla-central is better than not having it work at all. r+ with the ifdef.
Attachment #8440292 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/57f27c039661
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/57f27c039661
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•