Closed Bug 1025497 Opened 6 years ago Closed 6 years ago

Stop using gfxImageSurface in Cocoa widget code

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

Stop using gfxImageSurface in Cocoa widget code
Attached patch patchSplinter Review
Attachment #8440297 - Flags: review?(mstange)
Comment on attachment 8440297 [details] [diff] [review]
patch

I think I see a few refactoring opportunities around this code...
Attachment #8440297 - Flags: review?(mstange) → review+
For the record, what's the motivation for doing this?
Getting rid of the parts of Thebes that duplicate Moz2D. Redundant duplication of APIs is bad for many reasons.
(In reply to Markus Stange [:mstange] from comment #2)
> I think I see a few refactoring opportunities around this code...

I'll review if you like. :)
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/121cf7ced13d for b2g, linux32 debug and static-analysis (which might be the same as saying "GCC," not sure) bustage.
https://hg.mozilla.org/mozilla-central/rev/7ba4ba052721
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.