1025497 - Stop using gfxImageSurface in Cocoa widget code

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Jonathan Watt [:jwatt]]

Stop using gfxImageSurface in Cocoa widget code

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 8440297 [details] [diff] [review]
patch

I think I see a few refactoring opportunities around this code...

Comment 3

[Steven Michaud [:smichaud] (Retired)]

For the record, what's the motivation for doing this?

Comment 4

[Jonathan Watt [:jwatt]]

Getting rid of the parts of Thebes that duplicate Moz2D. Redundant duplication of APIs is bad for many reasons.

Comment 5

[Jonathan Watt [:jwatt]]

(In reply to Markus Stange [:mstange] from comment #2)
> I think I see a few refactoring opportunities around this code...

I'll review if you like. :)

Comment 6

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/53e5f619cb62

Comment 7

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/121cf7ced13d for b2g, linux32 debug and static-analysis (which might be the same as saying "GCC," not sure) bustage.

Comment 8

[Jonathan Watt [:jwatt]]

Comment on attachment 8440297 [details] [diff] [review]
patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ba4ba052721

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7ba4ba052721