1025499 - [Search] Intermittent failure, Vertical - Search Search for app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Kevin Grandon :kgrandon]

It appears we have a new intermittent after landing the search notification. Probably missing a wait somewhere.


1) Vertical - Search Search for app:

Error: timeout exceeded!

at Object.Client.waitForSync (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:682:16)

at Object.Client.waitFor (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:650:60)

at Object.MarionetteHelper.waitForElement (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-helper/index.js:142:12)

at Object.Search.triggerFirstRun (/home/travis/build/mozilla-b2g/gaia/apps/search/test/marionette/lib/search.js:95:8)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/verticalhome/test/marionette/search_test.js:30:12)

at callFn (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:223:21)

at Test.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:216:7)

at Runner.runTest (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:373:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:451:12

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:298:14)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:308:7

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:246:23)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:270:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at callFn (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:228:7)

at Hook.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:216:7)

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:258:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:270:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:199:9

at Object.executeHook (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:369:18)

at process._tickCallback (node.js:415:13)

Comment 1

[Dale Harvey (:daleharvey)]

Ill take a look at this as well, didnt hit it myself

Comment 2

[Kevin Grandon :kgrandon]

Attachment: Github pull request

(In reply to Dale Harvey (:daleharvey) from comment #1)
> Ill take a look at this as well, didnt hit it myself

Ah, didn't think you'd be around, but I'm working on a patch already...

Should have 50 green runs: https://travis-ci.org/mozilla-b2g/gaia/builds/27574826

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8440306 [details] [review]
Github pull request

Dale - I think this is reasonable, just defaulting the value to true, and asyncStorage should always run before the user gets to three characters. Thoughts?

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 8440306 [details] [review]
Github pull request

That looks good, cheers

Comment 5

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/5ece812ce985df286b6e29d0aa503f76e6b31d7b

Comment 6

[Kevin Grandon :kgrandon]

A=test_only.

Uplifted: https://github.com/mozilla-b2g/gaia/commit/84aab7abd3c02c4c91c30435b911be1f44f259af