Closed
Bug 1025552
Opened 11 years ago
Closed 11 years ago
[Messages][Refactoring] Refactor attachment.js and specifically move rendering part to a separate module
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S5 (4july)
People
(Reporter: azasypkin, Assigned: azasypkin)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
*** Follow-up from bug 1012663 ***
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8440333 [details] [review]
GitHub pull request URL
Thanks for review! I've updated PR with 2 new commits per review round #1.
Attachment #8440333 -
Flags: review?(felash)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8440333 [details] [review]
GitHub pull request URL
I couldn't review fully but I think you have enough comments to move forward.
Attachment #8440333 -
Flags: review?(felash)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8440333 [details] [review]
GitHub pull request URL
Thanks! I believe it's ready for review again :) I've just left small doubt\question regarding to "_getBaseMarkup" nit.
Attachment #8440333 -
Flags: review?(felash)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8440333 [details] [review]
GitHub pull request URL
Answered on github and redirecting to Steve :)
Attachment #8440333 -
Flags: review?(felash) → review?(schung)
|
||
Comment 6•11 years ago
|
||
I only have some concern in image canvas leak, but the rest part looks fine for me.
|
|
Assignee | |
Updated•11 years ago
|
Blocks: sms-sprint-4
|
|
||
Updated•11 years ago
|
Whiteboard: [p=1][not-part-of-initial-sprint] → [p=1]
|
|
Assignee | |
Updated•11 years ago
|
Target Milestone: 2.0 S4 (20june) → 2.0 S5 (4july)
|
|
||
Comment 7•11 years ago
|
||
I think it's last question for this patch: About the attachment_renderer prototype in https://github.com/mozilla-b2g/gaia/pull/20376#discussion-diff-14138873
|
|
Assignee | |
Comment 8•11 years ago
|
||
(In reply to Steve Chung [:steveck] from comment #7)
> I think it's last question for this patch: About the attachment_renderer
> prototype in
> https://github.com/mozilla-b2g/gaia/pull/20376#discussion-diff-14138873
Replied and updated PR :)
|
|
||
Comment 9•11 years ago
|
||
Comment on attachment 8440333 [details] [review]
GitHub pull request URL
r=me and thanks for all the efforts!
Attachment #8440333 -
Flags: review?(schung) → review+
|
|
Assignee | |
Comment 10•11 years ago
|
||
(In reply to Steve Chung [:steveck] from comment #9)
> Comment on attachment 8440333 [details] [review]
> GitHub pull request URL
>
> r=me and thanks for all the efforts!
Thanks for review!
Master: https://github.com/mozilla-b2g/gaia/commit/05e735d94322124296958c3f2fbbd5b1c12db4e0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•