Closed Bug 1025552 Opened 10 years ago Closed 10 years ago

[Messages][Refactoring] Refactor attachment.js and specifically move rendering part to a separate module

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.0 S5 (4july)

People

(Reporter: azasypkin, Assigned: azasypkin)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file)

GitHub pull request URL
46 bytes, text/x-github-pull-request
steveck
: review+
Details | Review 
      No description provided.
*** Follow-up from bug 1012663 ***
Comment on attachment 8440333 [details] [review]
GitHub pull request URL

Thanks for review! I've updated PR with 2 new commits per review round #1.
Attachment #8440333 - Flags: review?(felash)
Comment on attachment 8440333 [details] [review]
GitHub pull request URL

I couldn't review fully but I think you have enough comments to move forward.
Attachment #8440333 - Flags: review?(felash)
Comment on attachment 8440333 [details] [review]
GitHub pull request URL

Thanks! I believe it's ready for review again :) I've just left small doubt\question regarding to "_getBaseMarkup" nit.
Attachment #8440333 - Flags: review?(felash)
Comment on attachment 8440333 [details] [review]
GitHub pull request URL

Answered on github and redirecting to Steve :)
Attachment #8440333 - Flags: review?(felash) → review?(schung)
I only have some concern in image canvas leak, but the rest part looks fine for me.
Blocks: sms-sprint-4
Whiteboard: [p=1][not-part-of-initial-sprint] → [p=1]
Target Milestone: 2.0 S4 (20june) → 2.0 S5 (4july)
I think it's last question for this patch: About the attachment_renderer prototype in https://github.com/mozilla-b2g/gaia/pull/20376#discussion-diff-14138873
(In reply to Steve Chung [:steveck] from comment #7)
> I think it's last question for this patch: About the attachment_renderer
> prototype in
> https://github.com/mozilla-b2g/gaia/pull/20376#discussion-diff-14138873

Replied and updated PR :)
Comment on attachment 8440333 [details] [review]
GitHub pull request URL

r=me and thanks for all the efforts!
Attachment #8440333 - Flags: review?(schung) → review+
(In reply to Steve Chung [:steveck] from comment #9)
> Comment on attachment 8440333 [details] [review]
> GitHub pull request URL
> 
> r=me and thanks for all the efforts!

Thanks for review!

Master: https://github.com/mozilla-b2g/gaia/commit/05e735d94322124296958c3f2fbbd5b1c12db4e0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: