Closed Bug 1025575 Opened 6 years ago Closed 6 years ago

[Settings][l12y] Do not reuse "Search Suggestions" string in different contexts

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

x86_64
Linux
defect
Not set

Tracking

(blocking-b2g:2.0+, b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.0 S4 (20june)
blocking-b2g 2.0+
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: tchevalier, Assigned: tchevalier)

References

Details

(Keywords: l12y, late-l10n, Whiteboard: [systemsfe])

Attachments

(1 file)

The following string:

 search-suggestions=Search Suggestions

is displayed as:

- a button
- a header
- a label

We must use 3 different strings, many locales can't properly localize this string.
See https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Don%27t_reuse_strings_in_different_contexts

I'll provide a patch.

Technically, it will break string freeze on the dashboard, but in reality it won't if we use:
search-suggestions=Search Suggestions
search-suggestions-button={{search-suggestions}}
search-suggestions-header={{search-suggestions}}

It will reuse the existing translations for search-suggestions by default, but localizers will be able to override it as they will.
Thanks for filing Théo. Feel free to assign to either Dale Harvey or myself if you'd like us to write the patch.
(In reply to Kevin Grandon :kgrandon from comment #1)
> Thanks for filing Théo. Feel free to assign to either Dale Harvey or myself
> if you'd like us to write the patch.

Thanks Kevin! I know you guys have a bunch of work these days, I'll try to save you some time :) This one should be trivial
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking+]
Whiteboard: [systemsfe]
Blocks: 1015336
No longer blocks: vertical-homescreen
Keywords: late-l10n
blocking-b2g: 2.0? → 2.0+
Comment on attachment 8441456 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20624

Nice work, Théo. It looks good to me! 

Please make sure all tests got passed before merging, thanks ;)
Attachment #8441456 - Flags: review?(ejchen) → review+
Thanks Ej
Errors on https://tbpl.mozilla.org/?tree=Gaia-Try&rev=b1f9872b6134de34ce216f19458dd11c8d8201f8 seems unrelated.
Note that we need to merge this one on 2.0 before Friday
Keywords: checkin-needed
Thanks guys, landed: https://github.com/mozilla-b2g/gaia/commit/6a2d8964017778accddaa3bcd45a6d10c876dfbb
Assignee: nobody → tchevalier
Status: NEW → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.