1025593 - [tracking] bugs found by PVS-Studio Standalone analyzer

Status: RESOLVED DUPLICATE of bug 710966

(Core Graveyard :: Tracking, defect)

Description

[Andrey Karpov]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140506152807

Steps to reproduce:

We already checked Mozilla Firefox with the PVS-Studio analyzer three years ago. It was pretty inconvenient and troublesome at the time. You see, there is no Visual Studio project file for Firefox – the build is done with the help of makefiles. That's why you can't just take and check the project. We had to integrate PVS-Studio into the build system, which appeared a difficult task. If I remember it rightly, it all resulted in successfully analyzing only a part of the project. But everything is different now that we have PVS-Studio Standalone. We can now monitoring all compiler launches and easily check the project.

Article: http://www.viva64.com/en/b/0262/

Comment 1

[Mardeg]

Can you say which version of Firefox was checked for that article? I can't see that mentioned in it.

Comment 2

[:Gijs (he/him)]

(In reply to Andrey Karpov from comment #0)
> We already checked Mozilla Firefox with the PVS-Studio analyzer three years
> ago. It was pretty inconvenient and troublesome at the time. You see, there
> is no Visual Studio project file for Firefox – the build is done with the
> help of makefiles.

This is no longer the case. You can build an msvs project file now using ./mach.

Comment 3

[Andrey Karpov]

I can't tell you exactly about the version - we downloaded the source code in the beginning of this month. Well, the version number doesn't matter actually. The purpose of the article was not to enumerate all the detected errors, but to show PVS-Studio's capabilities. You can check the project yourself - it will make more sense then. If you face any problems, we will help you solve them.

Comment 4

[Mardeg]

Andrey

Comment 5

[Mardeg]

(In reply to Andrey Karpov from comment #3)
> I can't tell you exactly about the version - we downloaded the source code
> in the beginning of this month.
I was asking whether the source was from mozilla-central (nightly trunk) or another branch like the Release channel, to save me time looking to file bugs on the examples in case they've already been fixed since then. I certainly don't have Windows or a machine with enough RAM to compile at the moment.
I changed this bug to a tracking one because otherwise it was just an advertisement.

Comment 7

[Wayne Mery (:wsmwk)]

wouldn't a techinical forum be a good place to cover this?

Comment 8

[Mardeg]

(In reply to Wayne Mery (:wsmwk) from comment #7)
> wouldn't a techinical forum be a good place to cover this?
Sure, if you want to close this in favour of a more appropriate place go ahead.

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to Mardeg from comment #8)
> (In reply to Wayne Mery (:wsmwk) from comment #7)
> > wouldn't a techinical forum be a good place to cover this?
> Sure, if you want to close this in favour of a more appropriate place go
> ahead.

Unless Andrey's intention is really what the summary says, to run PVS and file more bugs against this, but the bug just started out as more of a discussion of "how to do it?".  

Andrey, do you have all the information you need?

Comment 10

[Tristan Miller]

Wayne, I suspect this "bug" is just an attempt by Andrey to advertise PVS-Studio, a commercial product he develops.  There are similar ads masquerading as bug reports on other free software issue trackers, such as that of the Linux kernel and LibreOffice: https://bugzilla.kernel.org/show_bug.cgi?id=90661 https://bugs.documentfoundation.org/show_bug.cgi?id=89755

At any rate, we already have a tracking bug for issues found by this tool: Bug 710966.  This one can probably be closed as a duplicate.