Closed Bug 1025711 Opened 7 years ago Closed 7 years ago
[email/sanitizer] Quiet bleach
.js CSS parser errors
The CSS parser in bleach.js can get very upset with the CSS from emails we feed it and can output a lot of warnings/errors that we don't care about but could seem like things we care about. Better to not log them at all.
Note that the CSS parser files for some reason have ^M's so the patches do too. git diff may show this without conveying that they're everywhere. I'm not doing anything about that in this patch.
Assignee: nobody → bugmail
Status: NEW → ASSIGNED
Attachment #8440469 - Flags: review?(jrburke)
Attachment #8440469 - Flags: review?(jrburke) → review+
Debug-wise, agreed. I think it would be most useful to direct the CSS parser's logging to a discrete logging channel that's not output to logcat but would show up in unit tests and in secret debug mode/its successor. I'm going to punt on filing a bug on this for now since we don't have a need yet and there will be some churn as we overhaul back-end logging/secret debug mode a bit. Yes, those look like Gecko CSS warnings. I suppose if we ever see those it's probably an indication that our sanitizer could do a better job since something Gecko throws away at display time is just wasted storage space for us.
landed on bleach.js/worker-thread-friendly: https://github.com/mozilla-b2g/bleach.js/pull/8 https://github.com/mozilla-b2g/bleach.js/commit/d2d833dec4b6a8d10793e2e4605e847af70cf382 landed on gelam/master: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/314 https://github.com/mozilla-b2g/gaia-email-libs-and-more/commit/7a50a3d34058214174841146ab96e79b9d5735ed landed on gaia/master: https://github.com/mozilla-b2g/gaia/pull/20652 https://github.com/mozilla-b2g/gaia/commit/e73e53a9a6fb7e57aba00d3da279edc12f0180e3
You need to log in before you can comment on or make changes to this bug.