1025741 - Firefox 30 crashes on console.time in HTML page generated by XSLT

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[rick]

Attachment: test.xml

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36

Steps to reproduce:

1. Save test.xml and test.xsl to the same directory
2. Run a webserver to serve these files
3. Visit test.xml in Firefox 30.

Note: if you comment out line 29 of test.xsl

//window.console.time("boom!");

then Firefox no longer crashes.




Actual results:

Firefox crashes (shows "Mozilla Crash Reporter").



Expected results:

Firefox should have displayed the page without error.

Comment 1

[rick]

Attachment: xsl file

Comment 2

[Boris Zbarsky [:bzbarsky]]

Under the hood, this is caused by bug 804069.

But more immediately, it's caused by this code in Console.cpp:

912       nsRefPtr<nsPerformance> performance = win->GetPerformance(rv);
913       if (rv.Failed()) {
914         return;
915       }
916 
917       callData->mMonotonicTimer = performance->Now();

where bug 804069 causes "performance" to be null while rv.Failed() is false.

So we can fix the crash by null-checking here, but until bug 804069 is fixed console.time() simply won't work right in XSLT-generated pages...

Andrea, do you have time for this?

Comment 3

[Andrea Marchesini [:baku]]

Attachment: bug.patch

Do you mean, this simple null-check?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8440736 [details] [diff] [review]
bug.patch

Right, this just disables time() in XSLT-generated pages...

Comment 5

[Andrea Marchesini [:baku]]

m-i is closed.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Sorry Andrea, but per the dev-platform post a few weeks ago, we require Try links to push checkin-needed patches now.

Comment 7

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=0e521560754a

Comment 8

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/28894f6cf1ff

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/28894f6cf1ff