Closed
Bug 1025767
Opened 11 years ago
Closed 11 years ago
Add explicit timeout to remote verifier requests
Categories
(Cloud Services Graveyard :: Server: Token, defect)
Cloud Services Graveyard
Server: Token
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: rfkelly, Assigned: rfkelly)
Details
(Whiteboard: [qa+])
Attachments
(1 file)
|
1.48 KB,
patch
|
francois
:
review+
|
Details | Diff | Splinter Review |
As noted in Bug 1014496 Comment 20, requests to the remote verifier should have an explicit timeout so that we can fail them cleanly, rather than wait for the client and/or nginx to give up on us.
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → rfkelly
Attachment #8440535 -
Flags: review?(dan.callahan)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8440535 [details] [diff] [review]
ts-verifier-request-timeout.diff
asking :fmarier for a sanity-check r? on this and then I'll prep a new tag for release
Attachment #8440535 -
Flags: review?(dan.callahan) → review?(francois)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8440535 [details] [diff] [review]
ts-verifier-request-timeout.diff
Review of attachment 8440535 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #8440535 -
Flags: review?(francois) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Whiteboard: [qa+]
|
|
||
Comment 5•11 years ago
|
||
I believe this is now out in Stage and Production:
Stage Deploy: bug 1014496
Prod Deploy: bug 1027899
Status: RESOLVED → VERIFIED
|
||
Updated•2 years ago
|
Product: Cloud Services → Cloud Services Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•