1025808 - Need a "disabled" style for the key after the new visual update

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: disabled_key.png

STR
===
1. Enable Greek keyboard layout, with:
   GAIA_KEYBOARD_LAYOUTS=en,pt-BR,es,de,fr,pl,zh-Hans-Pinyin,en-Dvorak,el make install-gaia

 2. Switch to Message app > New Message > Click on the message compose input field.

  => The disabled key style is not consistent with the new visual style.
     Please refer to the screenshot.

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: disabled_key.png

Highligh the area for the disabled key.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi Omega,

Could you please help on this issue?
Thank you.

Comment 3

[Omega Feng [:Omega] [:馮於懋]]

Hi Carol, please help on this, thanks!

Comment 4

[Carol Huang [:Carol]]

Attachment: Greek_disabled shift key_UI.jpg

Hi Rudy,
Please see the visual UI spec.

thanks!

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

The spec Looks good to me.
Carol, thanks.

Put this into [good first bug].

Comment 6

[Sébastien Blin [:sblin] [:amarok]]

I can try to work on this bug.

Comment 7

[Sébastien Blin [:sblin] [:amarok]]

Attachment: Need a disabled style for the key after the new visual update.

Comment 8

[Sébastien Blin [:sblin] [:amarok]]

This is my first patch for Gaia and my first test of git bz.

Comment 9

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 8443957 [details] [diff] [review]
Need a disabled style for the key after the new visual update.

Stealing review.

Comment 10

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: State on device, wrong background color

Hi Sebastien, thanks for contributing. The background color of a disabled key is different than that of normal keys, that's not the case in the linked visual spec. Can you fix that and re-ask for review? Thanks!

Comment 11

[Sébastien Blin [:sblin] [:amarok]]

Ok I will fix that in the following days and re-ask for review

Comment 12

[Sébastien Blin [:sblin] [:amarok]]

Attachment: Need a disabled style for the key after the new visual update.

Comment 13

[Sébastien Blin [:sblin] [:amarok]]

Attachment: Need a disabled style for the key after the new visual update.

Comment 14

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 8444614 [details] [diff] [review]
Need a disabled style for the key after the new visual update.

r=janjongboom. Thanks a lot for contributing!

Some nits for the next time:

* There is an extra newline at the bottom of the file. I'm pretty sure git already warns you when you export the patch but please pay attention. I've fixed it for you.
* Commit messages should not include the r=XXX part. For gaia we include this in the merge commit. It's not always clear who will be the reviewer ahead of time. In Gecko we generally do have it though, so it's a bit of a gaia thing.
* Adding patches as patch files (like you did in this patch) is totally OK, but most people use Merge Requests on GitHub for patches. It makes reviewing & landing easier. If you don't like that flow, you can use patch files.

Landed https://github.com/mozilla-b2g/gaia/commit/795fe2f7643000859cb735449952d20c9d4b6fb2

Comment 15

[Sébastien Blin [:sblin] [:amarok]]

Cool, Thank you for your advice. (Sorry for the new line, I didn't see it. For future patch I will use github, but for this patch I used git bz to test it.)