Closed Bug 1025835 Opened 5 years ago Closed 5 years ago

[Vertical Homescreen] Loading animation while downloading app is broken

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S4 (20june)
blocking-b2g 2.0+
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(3 files)

Attached image Spinner broken.png
No description provided.
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Whiteboard: [systemsfe]
Attached file Github pull request
Attachment #8440601 - Flags: review?(kgrandon)
I implemented it without seeing bug 1023950. However I think that this is a must to have and the other one is an incredible nice to have. James, do you want to close it or not?
Flags: needinfo?(jlal)
Needed for parity with old homescreen & also likely a VD blocker.
blocking-b2g: --- → 2.0?
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking+]
Comment on attachment 8440601 [details]
Github pull request

I am ok to fix this for now, but I think James might be revisiting this a bit in bug 1023950. I don't want to interfere with his work too much, so forwarding the R? to him.
Attachment #8440601 - Flags: review?(kgrandon)
Attachment #8440601 - Flags: review?(jlal)
Attachment #8440601 - Flags: feedback+
Blocks: 1015336
No longer blocks: vertical-homescreen
blocking-b2g: 2.0? → 2.0+
James could you take a look at this review? thanks a lot
Comment on attachment 8440601 [details]
Github pull request

This looks fine to me but https://bugzilla.mozilla.org/show_bug.cgi?id=1023950 will entirely override these changes so I am tempted to not land this. I need to port the media query heights over in that patch still...
Attachment #8440601 - Flags: review?(jlal) → review+
Flags: needinfo?(jlal)
https://github.com/mozilla-b2g/gaia/commit/c015bc0188daec0898c0023221cb589087bb1b26
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S4 (20june)
Status: RESOLVED → VERIFIED
Attached video VIDEO0125_Compress.MP4
This issue has been successfully verified on Flame 2.0:
Gaia-Rev        3aa0797c111a40e36f722722309668de3d469181
Gecko-Rev       93efc8b4155f0a4a50eaad19acbb95ec24139e63
Build-ID        20141204050313
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0
Device-Name     flame
FW-Release      4.4.2
You need to log in before you can comment on or make changes to this bug.