Add "version" prefix to version number in HTML report

RESOLVED FIXED in mozilla33

Status

Testing
Marionette
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: davehunt, Assigned: abotalov)

Tracking

({ateam-marionette-runner})

Trunk
mozilla33
ateam-marionette-runner
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=davehunt][lang=py][good first bug][affects=gaia])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
The HTML report currently shows the package name and version used to generate it. In bug 1024979 we modified the package name to include the Gaia branch, which makes it difficult to visually separate the version. We should add a "version" prefix so the output is clear.

Example of current output:
Report generated on 15-Jun-2014 at 18:26:44 by gaiatest 0.23

Example of desired output:
Report generated on 15-Jun-2014 at 18:26:44 by gaiatest version 0.23

Here's the line of code that needs updating: http://hg.mozilla.org/mozilla-central/file/80431d4fd0da/testing/marionette/client/marionette/runner/mixins/reporting.py#l192
Keywords: ateam-marionette-runner
Whiteboard: [mentor=davehunt][lang=py][good first bug] → [mentor=davehunt][lang=py][good first bug][affects=gaia]
(Reporter)

Comment 2

4 years ago
That's great. Could you please submit it as a patch? You'll find some help here: https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Assignee: nobody → botalov.andrey
Status: NEW → ASSIGNED
(Assignee)

Comment 3

4 years ago
Created attachment 8440688 [details] [diff] [review]
0001-Add-indication-that-it-s-version-to-HTML-report.patch
(Reporter)

Comment 4

4 years ago
The patch looks great, we just need to tidy up the commit message. It's currently:

> Add indication that it's version to HTML report

Please add a reference to the bug number and add the details of the reviewer. Often the bug summary is a suitable commit message, so long as it describes the change. I can review this patch, so something like the following would be great:

> Bug 1025838 - Add 'version' prefix to version number in HTML report. r=dhunt

When you've made this change, be sure to set me as the reviewer in Bugzilla, so that I get a notification.
(Assignee)

Comment 5

4 years ago
Created attachment 8440690 [details] [diff] [review]
0001-Add-indication-that-it-s-version-to-HTML-report.patch
(Assignee)

Updated

4 years ago
Attachment #8440690 - Flags: review?(dave.hunt)
(Reporter)

Comment 6

4 years ago
Comment on attachment 8440690 [details] [diff] [review]
0001-Add-indication-that-it-s-version-to-HTML-report.patch

Review of attachment 8440690 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks!
Attachment #8440690 - Flags: review?(dave.hunt) → review+
(Reporter)

Updated

4 years ago
Keywords: checkin-needed
Attachment #8440688 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/a0514f1cbbe2
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.