1025838 - Add "version" prefix to version number in HTML report

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

The HTML report currently shows the package name and version used to generate it. In bug 1024979 we modified the package name to include the Gaia branch, which makes it difficult to visually separate the version. We should add a "version" prefix so the output is clear.

Example of current output:
Report generated on 15-Jun-2014 at 18:26:44 by gaiatest 0.23

Example of desired output:
Report generated on 15-Jun-2014 at 18:26:44 by gaiatest version 0.23

Here's the line of code that needs updating: http://hg.mozilla.org/mozilla-central/file/80431d4fd0da/testing/marionette/client/marionette/runner/mixins/reporting.py#l192

Comment 1

[Andrei Botalov [:abotalov]]

Here - https://github.com/abotalov/gecko-dev/commit/51c8c2f14ac986efe764b869f09bf935c3a97923

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

That's great. Could you please submit it as a patch? You'll find some help here: https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 3

[Andrei Botalov [:abotalov]]

Attachment: 0001-Add-indication-that-it-s-version-to-HTML-report.patch

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

The patch looks great, we just need to tidy up the commit message. It's currently:

> Add indication that it's version to HTML report

Please add a reference to the bug number and add the details of the reviewer. Often the bug summary is a suitable commit message, so long as it describes the change. I can review this patch, so something like the following would be great:

> Bug 1025838 - Add 'version' prefix to version number in HTML report. r=dhunt

When you've made this change, be sure to set me as the reviewer in Bugzilla, so that I get a notification.

Comment 5

[Andrei Botalov [:abotalov]]

Attachment: 0001-Add-indication-that-it-s-version-to-HTML-report.patch

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8440690 [details] [diff] [review]
0001-Add-indication-that-it-s-version-to-HTML-report.patch

Review of attachment 8440690 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/a0514f1cbbe2

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a0514f1cbbe2