Closed
Bug 1025848
Opened 10 years ago
Closed 10 years ago
[Vertical Homescreen] Gesture with two or more fingers ends in edit mode or showing the context menu
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(b2g-v2.0 fixed, b2g-v2.1 fixed)
VERIFIED
FIXED
2.0 S4 (20june)
People
(Reporter: crdlc, Assigned: crdlc)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
190 bytes,
text/html
|
kgrandon
:
review+
bajaj
:
approval-gaia-v2.0+
|
Details |
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Blocks: vertical-homescreen
Assignee | ||
Updated•10 years ago
|
Whiteboard: [systemsfe]
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8440618 -
Flags: review?(kgrandon)
Updated•10 years ago
|
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
Updated•10 years ago
|
Comment 3•10 years ago
|
||
Comment on attachment 8440618 [details]
Github pull request
Looks good to me. I've heard reports of this, but wasn't able to reproduce it, everything seems to work well with it.
Requesting approval for 2.0 - this is necessary for the vertical homescreen.
Attachment #8440618 -
Flags: review?(kgrandon)
Attachment #8440618 -
Flags: review+
Attachment #8440618 -
Flags: approval-gaia-v2.0?(bbajaj)
Comment 4•10 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/8af12a362080bb2e3b4997437c0078c7f3cfe3cf
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
status-b2g-v2.0:
--- → affected
status-b2g-v2.1:
--- → fixed
Flags: needinfo?(jlorenzo)
Keywords: verifyme
Updated•10 years ago
|
Attachment #8440618 -
Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Comment 5•10 years ago
|
||
Verified on master. Pinch to zoom does not trigger edit mode anymore.
Comment 6•10 years ago
|
||
Needs a either a branch patch for uplift or other deps to be approved as well.
Comment 8•10 years ago
|
||
Uplifted: https://github.com/mozilla-b2g/gaia/commit/bc548e895b6b2f09c23d7cd33b66f9b1bda49a08
Keywords: branch-patch-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•