Closed Bug 1025855 Opened 5 years ago Closed 5 years ago
[Vertical Homescreen] Wrong box shadow for bookmarks in edit mode
Regression from 1023817
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Cristian - What's the bug here? I can't tell by the screenshots.
Comment on attachment 8440638 [details] Github pull request Seems to work, thanks!
Attachment #8440638 - Flags: review?(kgrandon) → review+
The bug is that the background was spanning the entire width, it should only be as wide as the text is (plus some padding). Landed: https://github.com/mozilla-b2g/gaia/commit/9cc5cd6627c475437886be9ac7f407cd5425a412
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8440638 [details] Github pull request This is needed for the vertical homescreen. We've done our best at testing this patch, and believe it should be safe for uplift. Thanks!
Attachment #8440638 - Flags: approval-gaia-v2.0?(bbajaj)
I cannot add more info, explained properly :) Thanks Kevin (In reply to Kevin Grandon :kgrandon from comment #5) > The bug is that the background was spanning the entire width, it should only > be as wide as the text is (plus some padding). > > Landed: > https://github.com/mozilla-b2g/gaia/commit/ > 9cc5cd6627c475437886be9ac7f407cd5425a412
Attachment #8440638 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
This issue has been successfully verified on Flame 2.0: Gaia-Rev 8d1e868864c8a8f1e037685f0656d1da70d08c06 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3 Build-ID 20141201000201 Version 32.0 Device-Name flame FW-Release 4.4.2 This issue has been successfully verified on Flame 2.1: Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22 Build-ID 20141201001201 Version 34.0 Device-Name flame FW-Release 4.4.2
You need to log in before you can comment on or make changes to this bug.