Closed
Bug 1025855
Opened 7 years ago
Closed 7 years ago
[Vertical Homescreen] Wrong box shadow for bookmarks in edit mode
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(b2g-v2.0 verified, b2g-v2.1 verified)
VERIFIED
FIXED
2.0 S4 (20june)
People
(Reporter: crdlc, Assigned: crdlc)
References
Details
(Keywords: regression, Whiteboard: [systemsfe])
Attachments
(4 files)
Regression from 1023817
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Blocks: vertical-homescreen
Depends on: 1023817
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8440638 -
Flags: review?(kgrandon)
Comment 3•7 years ago
|
||
Cristian - What's the bug here? I can't tell by the screenshots.
Flags: needinfo?(crdlc)
Updated•7 years ago
|
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking?]
Comment 4•7 years ago
|
||
Comment on attachment 8440638 [details]
Github pull request
Seems to work, thanks!
Attachment #8440638 -
Flags: review?(kgrandon) → review+
Comment 5•7 years ago
|
||
The bug is that the background was spanning the entire width, it should only be as wide as the text is (plus some padding). Landed: https://github.com/mozilla-b2g/gaia/commit/9cc5cd6627c475437886be9ac7f407cd5425a412
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: needinfo?(crdlc)
Resolution: --- → FIXED
Comment 6•7 years ago
|
||
Comment on attachment 8440638 [details]
Github pull request
This is needed for the vertical homescreen. We've done our best at testing this patch, and believe it should be safe for uplift. Thanks!
Attachment #8440638 -
Flags: approval-gaia-v2.0?(bbajaj)
Assignee | ||
Comment 7•7 years ago
|
||
I cannot add more info, explained properly :) Thanks Kevin (In reply to Kevin Grandon :kgrandon from comment #5) > The bug is that the background was spanning the entire width, it should only > be as wide as the text is (plus some padding). > > Landed: > https://github.com/mozilla-b2g/gaia/commit/ > 9cc5cd6627c475437886be9ac7f407cd5425a412
Updated•7 years ago
|
Target Milestone: --- → 2.0 S4 (20june)
Updated•7 years ago
|
status-b2g-v2.0:
--- → affected
status-b2g-v2.1:
--- → fixed
Updated•7 years ago
|
Attachment #8440638 -
Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Comment 8•7 years ago
|
||
Uplifted: https://github.com/mozilla-b2g/gaia/commit/71375794ce7ce5d979bb3925e9386e7ed6f742c4
This issue has been successfully verified on Flame 2.0: Gaia-Rev 8d1e868864c8a8f1e037685f0656d1da70d08c06 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3 Build-ID 20141201000201 Version 32.0 Device-Name flame FW-Release 4.4.2 This issue has been successfully verified on Flame 2.1: Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22 Build-ID 20141201001201 Version 34.0 Device-Name flame FW-Release 4.4.2
You need to log in
before you can comment on or make changes to this bug.
Description
•