1025887 - Exception isn't handled after "No builds available for 64 bit Windows" error

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Ed Morley [:emorley]]

On Win8.1 x64, running:
$ mozregression --app=thunderbird --good=2014-06-06 --bad=2014-06-11

Gives:
No builds available for 64 bit Windows (try specifying --bits=32)
Exception AttributeError: "'ThunderbirdNightly' object has no attribute 'persist'" in <bound method ThunderbirdNightly.cleanup of <mozregression.runnightly.ThunderbirdNightly object at 0x02F57370>> ignored

In bug 1025879 I initially missed the solution ("use --bits=32"), due to the spam from the exception making me not see it in the console.

Given we have a useful error message, please can we catch the exception? :-)

$ pip show mozregression
---
Name: mozregression
Version: 0.18

Comment 1

[:Gijs (he/him)]

(fwiw, this is specific to app=Thunderbird, and probably an unrelated error...)

Comment 2

[Julien Pagès (:parkouss)]

Attachment: fix the "no attribute persist" error when ThunderbirNightly is cleand - bug 1025887

The error appears because ThundebirdNightly is'nt properly initialized but garbage collected. Just move up the "self.persist = persist" line before any exception can happen solve the problem.

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8474650 [details] [review]
fix the "no attribute persist" error when ThunderbirNightly is cleand - bug 1025887

Makes sense, ty!

Comment 4

[Julien Pagès (:parkouss)]

Attachment: make mozregression use exceptions

This patch is a start for using exceptions in mozregression. It does not resolve this bug, but it is still related. I put it as a attachment here to make sure it will be reviewed. :)

Comment 5

[Sam Garrett]

Comment on attachment 8475785 [details] [review]
make mozregression use exceptions

I merged this in. Thanks!

Comment 6

[Julien Pagès (:parkouss)]

This bug may be close I suppose (see the merged Attachment #8474650 [details]). William, what do you think ?

Comment 7

[William Lachance (:wlach)]

Yes, it should be. Thanks Julien!