Closed Bug 1026091 Opened 6 years ago Closed 6 years ago

[Homescreen] 2.0 Smart Collections header style isn't consistent with OS headers

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(feature-b2g:-, b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S4 (20june)
feature-b2g -
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: amylee, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(5 files)

Header text style doesn't look consistent with  OS headers (centered, thin weight, italic). It should match the building block. See attached.
feature-b2g: --- → -
Attached image photography.png
Hola Arnau, I used the header BB but the text does not seem centered according to the device width. Should it be so? or is a problem related to BB?
Flags: needinfo?(arnau)
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attached file Github pull request
Attachment #8442765 - Flags: review?(amirn)
Guillaume,
Is there anything else Cristian needs to do in his patch to get the header title properly centered?
Thanks!
Flags: needinfo?(arnau) → needinfo?(gmarty)
Hi Cristian. You need to add the following JS file `/shared/js/font_size_utils.js`.
Then all the headers will be auto-resized and centered.
Flags: needinfo?(gmarty)
Comment on attachment 8442765 [details]
Github pull request

The code looks ok, but the title is not centered in respect with the 'X' icon.
I am not sure if it should be centered to the empty header space or the entire header.

maybe ask for UX review?
Attachment #8442765 - Flags: review?(amirn) → feedback+
Please let me know if this needs the ui-review? flag set for someone on our team. Can't tell from this if it's ready yet. Thanks!
Attached image Centered, thanks
It works like a charm, many thanks

(In reply to gmarty from comment #4)
> Hi Cristian. You need to add the following JS file
> `/shared/js/font_size_utils.js`.
> Then all the headers will be auto-resized and centered.
Attachment #8442765 - Flags: review?(arnau)
Comment on attachment 8442765 [details]
Github pull request

Looks good Cristian :)
Attachment #8442765 - Flags: review?(arnau) → review+
Merged in master:

https://github.com/crdlc/gaia/commit/78a9428121a0e12bed58125f851715543c72161d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S4 (20june)
Comment on attachment 8442765 [details]
Github pull request

Needed for the vertical homescreen.
Attachment #8442765 - Flags: approval-gaia-v2.0?(bbajaj)
Attachment #8442765 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Status: RESOLVED → VERIFIED
Attached video VIDEO0081.mp4
This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2


This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
You need to log in before you can comment on or make changes to this bug.