Closed Bug 1026091 Opened 6 years ago Closed 6 years ago
.0 Smart Collections header style isn't consistent with OS headers
198.26 KB, image/png
243.86 KB, image/png
190 bytes, text/html
243.96 KB, image/png
2.92 MB, video/mp4
Header text style doesn't look consistent with OS headers (centered, thin weight, italic). It should match the building block. See attached.
Hola Arnau, I used the header BB but the text does not seem centered according to the device width. Should it be so? or is a problem related to BB?
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Guillaume, Is there anything else Cristian needs to do in his patch to get the header title properly centered? Thanks!
Flags: needinfo?(arnau) → needinfo?(gmarty)
Hi Cristian. You need to add the following JS file `/shared/js/font_size_utils.js`. Then all the headers will be auto-resized and centered.
Comment on attachment 8442765 [details] Github pull request The code looks ok, but the title is not centered in respect with the 'X' icon. I am not sure if it should be centered to the empty header space or the entire header. maybe ask for UX review?
Attachment #8442765 - Flags: review?(amirn) → feedback+
Please let me know if this needs the ui-review? flag set for someone on our team. Can't tell from this if it's ready yet. Thanks!
It works like a charm, many thanks (In reply to gmarty from comment #4) > Hi Cristian. You need to add the following JS file > `/shared/js/font_size_utils.js`. > Then all the headers will be auto-resized and centered.
Attachment #8442765 - Flags: review?(arnau)
Comment on attachment 8442765 [details] Github pull request Looks good Cristian :)
Attachment #8442765 - Flags: review?(arnau) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S4 (20june)
Comment on attachment 8442765 [details] Github pull request Needed for the vertical homescreen.
Attachment #8442765 - Flags: approval-gaia-v2.0?(bbajaj)
Attachment #8442765 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
This issue has been successfully verified on Flame 2.0: Gaia-Rev 8d1e868864c8a8f1e037685f0656d1da70d08c06 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3 Build-ID 20141130000204 Version 32.0 Device-Name flame FW-Release 4.4.2 This issue has been successfully verified on Flame 2.1: Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22 Build-ID 20141130001203 Version 34.0 Device-Name flame FW-Release 4.4.2
You need to log in before you can comment on or make changes to this bug.