1026098 - [User Story] Skip time and timezone setting when network time available

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Comment 1

[Peter Dolanjski [:pdol]]

Fernando, how difficult is this?

Comment 2

[Fernando Campo (:fcampo)]

Not an expert on the matter, as all the developing of the timezone selection was made by Kaze, but after looking at the code I'd say it would be easy. 

Right now we check for the MCC/MNC combination to guess the timezone, and if we don't have it, fallback to America/New York. We could just show the screen if at the end of the process we end up with the default value.

I'd need to do some tests to check if the approach works, as we've had a lot of problems with detection on the past.

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Ted is going to take this one.

Comment 4

[Ted Clancy [:tedders1]]

Attachment: Bug 1026098 - Skip time and timezone setting when network time available.

Comment 5

[Fernando Campo (:fcampo)]

Comment on attachment 8463605 [details] [review]
Bug 1026098 - Skip time and timezone setting when network time available.

I left some comments on the PR, to move the logic to a different place, as we have a function 'skipStep' that we can use instead, so we do all the checks for steps in the same place.

Also, we need tests on this. Please flag me for review when done.

And thanks for taking care of it.

Comment 6

[Ted Clancy [:tedders1]]

Attachment: Skip time and timezone setting when network time available.

I added unit tests, and fixed the old unit tests too.

Comment 7

[Fernando Campo (:fcampo)]

Comment on attachment 8465057 [details] [review]
Skip time and timezone setting when network time available.

Left some comments, and a proposal for change. Tell me what do you think about it.
Looking good so far :)

Comment 8

[Ted Clancy [:tedders1]]

Thanks, Fernando. I've made the changes you suggested.

Comment 9

[Fernando Campo (:fcampo)]

Comment on attachment 8465057 [details] [review]
Skip time and timezone setting when network time available.

Looks great, thanks a lot!

Only comment left is to change 'SOURCE' variable to lowercase, linter is failing and patch doesn't work with that. I tested it after changing it, and works like a charm.

Merge whenever TBPL is happy :)

Comment 10

[Ted Clancy [:tedders1]]

D'oh! My bad.

Thanks, Fernando :-)

Comment 11

[Ted Clancy [:tedders1]]

Successful try run: https://tbpl.mozilla.org/?rev=440de7f061bc1035f22914053e07b2f2f471c7e1&tree=Gaia-Try

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/c35e15354cd18e78b79abd81b999749b326fef16

Comment 13

[Fernando Campo (:fcampo)]

Just tried with an up to date build (and gaia commit 254ecd807e539eee0b9a0af409b2f30cbb687fa5), and I can see the Date&Time screen after getting connected to the network. Flame, O2 UK SIM.
https://www.youtube.com/watch?v=y8Dz9jeZjEo

asking for qa to double check, and reopen or create new bug if needed.

Comment 14

[Jason Smith [:jsmith]]

(In reply to Fernando Campo (:fcampo) from comment #13)
> Just tried with an up to date build (and gaia commit
> 254ecd807e539eee0b9a0af409b2f30cbb687fa5), and I can see the Date&Time
> screen after getting connected to the network. Flame, O2 UK SIM.
> https://www.youtube.com/watch?v=y8Dz9jeZjEo
> 
> asking for qa to double check, and reopen or create new bug if needed.

The discussion on bug 1049149 summarizes we are seeing - we do see the timezone screen getting skipped when the network is detected, but the timezone isn't be set correctly. Does that answer your question?

If you are reproducing this with your own SIM, then I think we should open a separate bug for that.

Comment 15

[Fernando Campo (:fcampo)]

Thanks Jason, I'll open a new bug then, as I am still seeing the screen.

Comment 16

[Gerry Chang [:gchang]]

Add the test cases.
https://moztrap.mozilla.org/manage/cases/?filter-suite=750

Comment 17

[pete siphantong [:Petes]]

This issue is verified fixed on the flame 2.1 (319mb).

Environmental Variables:
Device: Flame Master
Build ID: 20140903000204
Gaia: fbb297c39aab5f17b179533d2a9a6c5166b2c197
Gecko: fb5e796da813
Version: 34.0a2 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

During FTE, tap 'next' on cellular data screen, the time/timezone selection will not be shown. User can use the device quicker by not setting the time and timezone.

During FTE, 'Enable Data' on cellular data screen, the time/timezone selection is shown.

Comment 18

[Seth Miko [:SMiko]]

After further investigation, The time/timezone selection is always skipped. 
When choosing to not enable data or wifi, the time/timezone selection is still skipped.
The only way to display the time/timezone selection screen is to remove the SIM card before beginning the FTE.

Comment 19

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Seth Miko [:SethM] from comment #18)
> After further investigation, The time/timezone selection is always skipped. 
> When choosing to not enable data or wifi, the time/timezone selection is
> still skipped.
> The only way to display the time/timezone selection screen is to remove the
> SIM card before beginning the FTE.

Seth, will you please file a new bug for this, and make it block this bug?

Comment 20

[Seth Miko [:SMiko]]

(In reply to Michael Henretty [:mhenretty] from comment #19)

> Seth, will you please file a new bug for this, and make it block this bug?

Done: Bug 1063001

Comment 21

[Seth Miko [:SMiko]]

Verified fixed. All depends on bugs are verified fixed, invalid, or duplicate.

Actual Result: date & time screen is skipped, when connected to a network. 

Flame 2.2

Environmental Variables:
Device: Flame 2.2 Master (319mb)
BuildID: 20140905040204
Gaia: 5765c62163bcb7fde5ebfd211881117de31a7c46
Gecko: dddbe46f3ceb
Version: 35.0a1 (2.2 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Comment 22

[Seth Miko [:SMiko]]

Verified on Flame 2.1 
Actual Result: date & time screen is skipped, when connected to a network.

Flame 2.1

Environmental Variables:
Device: Flame 2.1(319mb)
Build ID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0