1026129 - Replace some manual declarations of MSVC intrinsics with #include <intrin.h>

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P2)

Comment 1

[(no longer active)]

Attachment: Replace some manual declarations of MSVC intrinsics with #include <intrin.h>

Comment 2

[(no longer active)]

We need this because clang-cl maps these intirnsics to LLVM ones in its own intrin.h header, so trying to link against calls to those functions with clang-cl would fail with linking errors.

Comment 3

[(no longer active)]

Comment on attachment 8440912 [details] [diff] [review]
Replace some manual declarations of MSVC intrinsics with #include <intrin.h>

Requesting review from Ted as well in case he can review this sooner.  I'd like to get this landed sooner than later.

Comment 4

[(no longer active)]

Ping?

Comment 5

[Wan-Teh Chang]

Comment on attachment 8440912 [details] [diff] [review]
Replace some manual declarations of MSVC intrinsics with #include <intrin.h>

Review of attachment 8440912 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc. Sorry about the delay.

Patch checked in: https://hg.mozilla.org/projects/nspr/rev/ce8a360b2f8f

There was a reason why we declared the intrinsic functions manually, but
I don't remember why. I suspect the most likely reason was that MinGW or
older versions of MSVC don't have the <intrin.h> header.

I just did some research and found that Visual Studio .NET 2003 doesn't
have <intrin.h>. Its example code for _InterlockedDecrement says:
http://msdn.microsoft.com/en-us/library/f24ya7ct(v=vs.71).aspx

// To declare an interlocked function for use as an intrinsic,
// First, the function must be declared with the leading underscore.
// Second, the new function must appear in a #pragma intrinsic statement.

In contrast, the example code for _InterlockedDecrement in Visual Studio
2005 says:
http://msdn.microsoft.com/en-us/library/f24ya7ct(v=vs.80).aspx

// To declare an interlocked function for use as an intrinsic,
// include intrin.h and put the function in a #pragma intrinsic 
// statement.

Comment 6

[Wan-Teh Chang]

Patch pushed to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8ed1bc7528b

Comment 7

[(no longer active)]

Comment on attachment 8440912 [details] [diff] [review]
Replace some manual declarations of MSVC intrinsics with #include <intrin.h>

Thanks, Wan-Teh!

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b8ed1bc7528b