Closed Bug 1026166 Opened 10 years ago Closed 10 years ago

[vertical homescreen] Can activate actions on an icon through the edit header

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

x86
macOS
defect
Not set
normal

Tracking

(feature-b2g:2.0, b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S4 (20june)
feature-b2g 2.0
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: jsavory, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

Steps to reproduce:
1: Enter edit mode
2: Tap and hold on the edit mode header with an icon behind it

Expected Result: 
No action should take place, the header should act like other headers and prevent actions from behind it occurring. 

Actual Result:
Icon is highlighted and jumps in front of the header.
Blocks: vertical-home-next
No longer blocks: vertical-homescreen
QA Whiteboard: [VH
QA Whiteboard: [VH → [VH-FL-blocking-][VH-FC-blocking-]
I am able to reproduce it only if I tap on the edge of the header, not if my finger is clearly in the header. Do you also have this behavior Jacqueline?
Flags: needinfo?(jsavory)
For me, if I long press directly on the header I am able to trigger the icon behind it or the context menu will appear. 

I had flashed the latest master provided by Kevin earlier today and was seeing this behaviour. I just tried it with the latest build through the flash tool and I am getting the same result from there as well.
Flags: needinfo?(jsavory)
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attached file Github pull request
thanks Kevin!
Attachment #8441302 - Flags: review?(kgrandon)
Whiteboard: [systemsfe]
Comment on attachment 8441302 [details]
Github pull request

I wasn't really able to reproduce this, but lets see if this fixes it.
Attachment #8441302 - Flags: review?(kgrandon) → review+
feature-b2g: --- → 2.0
Target Milestone: --- → 2.0 S4 (20june)
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-] → [VH-FL-blocking+][VH-FC-blocking+]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8441302 [details]
Github pull request

This is needed for the vertical homescreen. We've done our best effort at testing this and believe it is safe for uplift.
Attachment #8441302 - Flags: approval-gaia-v2.0?(bbajaj)
Attachment #8441302 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Flags: in-moztrap?(jlorenzo)
Status: RESOLVED → VERIFIED
Attached video VIDEO0083.mp4
This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2


This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
Flags: in-moztrap?(jlorenzo)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: