Closed
Bug 1026187
Opened 10 years ago
Closed 10 years ago
Warnings displayed when running tests
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: evold, Assigned: zombie)
Details
Attachments
(1 file)
I see these in my console whenever I run tests: System JS : WARNING resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///var/folders/lc/2v6jzk5525gd4l6zr5hxt2yc0000gn/T/tmpu3gHrG.mozrunner/extensions/62973ad2-9593-47f8-8bf0-e3f4738ae046@jetpack.xpi!/bootstrap.js -> resource://extensions.modules.62973ad2-9593-47f8-8bf0-e3f4738ae046-at-jetpack.commonjs.path/toolkit/loader.js -> resource://extensions.modules.62973ad2-9593-47f8-8bf0-e3f4738ae046-at-jetpack.commonjs.path/sdk/test/harness.js:474 - mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create console.log: addon-sdk: [JavaScript Warning: "mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create" {file: "resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///var/folders/lc/2v6jzk5525gd4l6zr5hxt2yc0000gn/T/tmpu3gHrG.mozrunner/extensions/62973ad2-9593-47f8-8bf0-e3f4738ae046@jetpack.xpi!/bootstrap.js -> resource://extensions.modules.62973ad2-9593-47f8-8bf0-e3f4738ae046-at-jetpack.commonjs.path/toolkit/loader.js -> resource://extensions.modules.62973ad2-9593-47f8-8bf0-e3f4738ae046-at-jetpack.commonjs.path/sdk/test/harness.js" line: 474}]
Priority: -- → P1
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8447394 -
Flags: review?(zer0)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → tomica+amo
Status: NEW → ASSIGNED
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8447394 [details] [review] Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1526 r+ with all tests passing
Attachment #8447394 -
Flags: review?(zer0) → review+
|
||
Comment 3•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/68351d71d1f7c0213377b243a4f14d1477457dfc bug 1026187 - avoid setting __proto__ https://github.com/mozilla/addon-sdk/commit/95885476dcb280462383a35df3cb220ae69efc93 Merge pull request #1526 from zombie/1026187-proto-warning Bug 1026187 - avoid setting __proto__ r=@ZER0
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•