1026257 - Would like to be able to set default number of colums in vertical homescreen at build time

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Dave Hylands [:dhylands]]

I find the 3 column setting to be just too huge on my flame.

So I'd like to be able to somehow tweak the initial value of the preference that controls this at build time.

Normally, I would just create a custom-prefs.js or something, but the vertical home screen doesn't seem to use an actual setting.

For now, I'm editing https://github.com/mozilla-b2g/gaia/blob/master/shared/elements/gaia_grid/js/grid_layout.js#L44 and changing

> _cols : minIconsInRow

to be:

> _cols: 4

I also noticed that on my flame, when I use 4 columns that the rightmost column is slightly cut off, but I find that better than 3 columns.

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

thanks Kevin

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8441292 [details]
Github pull request

Clearing review for now, added a few comments to github.

Comment 3

[Kevin Grandon :kgrandon]

This is not something that really blocks the feature at all, I consider this more of a developer enhancement at this point. Not sure why it was marked as 2.0.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8441292 [details]
Github pull request

I like the changes, thanks.

Comment 5

[Cristian Rodriguez (:crdlc)]

Attachment: homescreens.json

You can copy this file to /gaia/distribution/ to test the feature

Comment 6

[Marcelino Veiga Tuimil [:sonmarce]]

It would be an interesting feature for OEMs & operators, giving them more flexibility to customize devices, so I would suggest to uplift it to 2.0

Comment 7

[Kevin Grandon :kgrandon]

We will request uplift for anything that lands in the next few weeks to not put vertical homescreen at risk. If we don't we will run into risks with merge conflicts.

Comment 8

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/crdlc/gaia/commit/f3e8effa420e22d1eadad5112311e43674a14d41

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8441292 [details]
Github pull request

This is needed for the vertical homescreen.

Comment 10

[Kevin Grandon :kgrandon]

2.0: https://github.com/mozilla-b2g/gaia/commit/060a9050dcd7475c3940ce16421ea28e6ed2241b

Comment 11

[Brogan Zumwalt [Inactive]]

Issue verified fixed on Flame 2.0, Flame 2.1, and Flame 2.2

Actual Results: User is able to see and modify variables for homescreen columns in gaia/apps/verticalhome/build/default-homescreens.json and see correct results after build.

Device: Flame 2.0 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141028000202
Gaia: 5e532a84e762b1bb6231756182cf1465671a061e
Gecko: 124f0bed1700
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141028001203
Gaia: a0174f7166745256aaca1cb3aa9f894033fbffa6
Gecko: 43bda3541f6b
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame Master (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141028040202
Gaia: 6a7fb482a03c5083ef79b41e7b0dfab27527cd04
Gecko: a255a234946e
Version: 36.0a1 (Master)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0