1026268 - [Vertical Homescreen] Cannot exit edit mode by tapping an empty space

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Johan Lorenzo [:jlorenzo]]

As per specs: "To exit edit mode, the user can tap the home button or tap on an empty space on the homepage".

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Thanks Kevin!

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8441228 [details]
Github pull request

Made some comments on github. You can land if you want to, with or without my comments addressed.

Comment 3

[Cristian Rodriguez (:crdlc)]

All comments were addressed

Merged in master:

https://github.com/crdlc/gaia/commit/8b3c09518f59704eaffc511899424236155766aa

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8441228 [details]
Github pull request

This is needed for the vertical homescreen. We've done our best effort at testing this and believe it is safe for uplift.

Comment 5

[Johan Lorenzo [:jlorenzo]]

Verified on master.

Comment 6

[Kevin Grandon :kgrandon]

2.0: https://github.com/mozilla-b2g/gaia/commit/bd654b0edd2bd0c49af2bf3a7c0a6e62e69a7c34

Comment 7

[Elie]

Attachment: VIDEO0813_Compress.MP4

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        3aa0797c111a40e36f722722309668de3d469181
Gecko-Rev       93efc8b4155f0a4a50eaad19acbb95ec24139e63
Build-ID        20141204050313
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0
Device-Name     flame
FW-Release      4.4.2