Closed Bug 1026268 Opened 6 years ago Closed 6 years ago

[Vertical Homescreen] Cannot exit edit mode by tapping an empty space

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(feature-b2g:2.0, b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S4 (20june)
feature-b2g 2.0
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: jlorenzo, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

As per specs: "To exit edit mode, the user can tap the home button or tap on an empty space on the homepage".
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attached file Github pull request
Thanks Kevin!
Attachment #8441228 - Flags: review?(kgrandon)
Comment on attachment 8441228 [details]
Github pull request

Made some comments on github. You can land if you want to, with or without my comments addressed.
Attachment #8441228 - Flags: review?(kgrandon) → review+
feature-b2g: --- → 2.0
Target Milestone: --- → 2.0 S4 (20june)
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-] → [VH-FL-blocking+][VH-FC-blocking+]
All comments were addressed

Merged in master:

https://github.com/crdlc/gaia/commit/8b3c09518f59704eaffc511899424236155766aa
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment on attachment 8441228 [details]
Github pull request

This is needed for the vertical homescreen. We've done our best effort at testing this and believe it is safe for uplift.
Attachment #8441228 - Flags: approval-gaia-v2.0?(bbajaj)
Verified on master.
Status: RESOLVED → VERIFIED
Attachment #8441228 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Flags: in-moztrap?(jlorenzo)
Attached video VIDEO0813_Compress.MP4
This issue has been successfully verified on Flame 2.0:
Gaia-Rev        3aa0797c111a40e36f722722309668de3d469181
Gecko-Rev       93efc8b4155f0a4a50eaad19acbb95ec24139e63
Build-ID        20141204050313
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0
Device-Name     flame
FW-Release      4.4.2
Flags: in-moztrap?(jlorenzo)
You need to log in before you can comment on or make changes to this bug.